Git Product home page Git Product logo

adg's People

Contributors

aerzas avatar andreasmoesch avatar andreasue avatar antonbolfing avatar backflip avatar carlobeltrame avatar christophdubach avatar damenleeturks avatar dependabot[bot] avatar estherbrunner avatar gracischuetz avatar gurix avatar jmuheim avatar lbsonley avatar manuelmeister avatar meodai avatar moltebeeri avatar nicsr avatar orioltf avatar ralf57 avatar rbottomley avatar rdeltour avatar renestalder avatar retoinniger avatar rspescha avatar rudigier avatar slkennedy avatar tetov avatar toddsiegel avatar yannisgu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

adg's Issues

Shareability

Add proper meta tags for sharing on Facebook, Twitter etc.

Use short title for menu

In the menu, the short title should be used.

Maybe the long title will be displayed as a tooltip; or even the lead text?

Refactor examples link to component(s)

In #36, the example links look great already:

image

But they're produced using a lot of spaghetti code. They need to be refactored into components: one for the example links themselves, and one for an accordion (called by the example links).

I have created the basic file structure and their contents:

image

But I need support in making them work and replacing the current spaghetti things.

Keep background colour when scrolling

I don't think that removing the background colour adds to legibility.

Also, keeping the background needs less specific CSS declarations, like the following bug (?) demonstrates:

image

And after scrolling:

image

Only re-process changed markdown files (instead of all)

I added a lot of content to the master branch, so our internal testers can test it. It is (nearly) the full selection of the final content.

As such, re-processing all markdown files all the time is extremely time-intensive, and we should configure the project in such a way that only changed files are re-processed.

SVG vs. PNG sprites implementation

For the time being, we stick to simple PNG backgrounds.

Before going live, we have to decide whether we use a sprites generator, or switch to SVG completely.

Extend navigation to more levels

Momentan scheint das Dropdown-Menü nur 1-stufig zu sein, so dass man zu tiefer verschachtelten Inhalten gar nicht so einfach kommen kann.

Wie wäre es, wenn entweder das Dropdown-Menü verschachtelt würde (gar nicht so trivial, da Bootstrap dies nicht von Haus aus anbietet)?

Oder man könnte auf der linken Seite ein Sub-Menü mit ggf. verschachtelten Listen anbieten. (Allerdings habe ich aktuell bewusst nur 2 Verschachtelungs-Stufen benutzt bisher, also wenn das Menü oben ein Dropdown-Menü bleibt, dann bräuchte es auf der linken Seite bis auf weiteres keine Verschachtelung.)

Use correct background colour for each part

Each part of the guide should have its dedicated background colour.

  • Welcome: orange image
    • Don't know whether orange is a good colour here...
  • Setup: red image
    • Red feels "technical" to me
  • Knowledge: blue image
    • Blue just feels right for me for knowledge
  • Examples: green image
    • As examples should resemble good ways to go, I think green gives a good signal

What do you think? Except green for examples I'm pretty open to other opinions.

Is the URL www.accessibility-developer-guide.com too long?

I'm thinking of whether www.accessibility-developer-guide.com is too long. On the other hand it is very "self-speaking".

What about the following URLs?

  • a11y-developer-guide.com
  • a11y-dev-guide.com
  • accessibility-developer.guide
  • a11y-developer.guide
  • a11y-dev.guide
  • a11y.guide

While using .guide TLD feels nice and freaky to me, I'm pretty unsure whether those verbose TLDs are already present in the collective awareness of internet users?

Also the numeronym a11y doesn't feel very prominent to me, especially for people new to accessibility, and the double 1 could easily be misinterpreted as double l (L).

And somehow, accessibility-developer.guide feels a bit strange to me, accessibility-development.guide feels better.

What do you guys think?

Examples layout

If possible, the examples should also be available in the ADG itself (not only Codepen), in a plain layout that doesn’t disturb (no headings, no special containers… just a visual frame for displaying the plain examples, maybe with a link "Back to the ADG" at the bottom).

While Codepen is a great service, it may not be ideal to run the examples in a screen reader easily (iframes, etc.).

Use Pug and SCSS (or Sass?) and maybe CoffeeScript for code examples

At the time being, the code examples are written in Slim, Sass and CoffeeScript.

In our project's frontend, we're using Pug (formerly Jade), SCSS and JavaScript.

We should unify all of this for two main reasons:

  1. To keep the code base uniform.
  2. To show people who don't know about preprocessors yet the advantages of them (it's incredible how many source code problems result from using plain HTML).

I suggest converting everything (frontend, examples) to:

  • Pug (formerly Jade)
  • SCSS (I prefer Sass, but the official recommendation is to use the SCSS syntax, as it is closer to original CSS)
  • CoffeeScript (though I'm not sure whether this would add dependencies we don't like?)

All of these should have support for automatic prettify, I guess?

There are several tools like http://html2jade.org/, sass-convert (http://sass-lang.com/documentation/file.SASS_REFERENCE.html), http://js2.coffee/ to help us with the conversion.

It would also be great to have the option to open examples on Codepen in either original version and compiled version (Codepen supports Pug, SCSS/Sass and CoffeeScript).

Indent pages' headings by 1 level

The heading levels in the README.md files need to be indented by 1, otherwise level 1 (the page’s main heading) and 2 (all sub titles) both are on the first level.

This is due to the fact that in my CMS, this happens automatically, and I don’t want the authors of content to need to worry about knowing on which level they should start.

If it’s not easy to fix that for the site generator, I could export everything so the headings start on level 2. What do you think, @backflip?

Visual focus states

I think we should have the same visual attributes for both hover and focus states: underline for text links and borders for other elements.

Optimise navigation

The menu needs to be working.

For the currently active menu item, please set a visually hidden text (current page) like so: "Semantics provide meaning (active page)", and for its parents use "(active parent)".

I’m unsure whether aria-expanded and aria-current would be good options here, but let’s stick to fool-proof techniques for the time being.

"Active" marker should not be announced by screen readers

Content added by CSS using content is announced by screen readers:

image

Instead of the >, we should either use a character that makes sense to be announced (for example an arrow to the right or a bullet or something like that), or even an emoji?

Remove title from metadata

We decided to remove the title from the metadata, as it is redundant there.

We keep the title as h1 in the markdown file, and indent each title of the content by 1 when exporting.

Improve Sitemap

The sitemap is already available but it does not contain all the URLs.
It should be improved so that it could also be used for search indexing purposes.

Search

Possibly using the Google Search Widget Thingie

Retina images

While creating screenshots on my Mac, i noticed that they are saved in retina resolution, which is too big for default websites.

Is it easily possible to implement both default and retina images? It would be a shame to have a crispy clean design for the ADG, but "smudged" low res images.

Lead text isn't displayed

The :lead element from the metadata isn't displayed. It should be displayed between the title (h1) and the content. It is always a single line of text (rendered into a paragraph by Markdown).

It should render in a distinguished font variant (see design).

Display link title attributes as tooltips

Im CMS habe ich es so gehandhabt, dass interne Links ohne Benennung im Markup autom. durch den Titel der referenzierten Seite ersetzt werden, z.B.:

Bitte lesen Sie dies: [](seite-xy)

Wird zu:

Bitte lesen Sie dies: <a href="...">Titel der Seite XY</a>

Und wenn man eine Benennung gab, dann wurde der tatsächliche Titel als title Attribut hinzugefügt:

Bitte lesen Sie [hier](seite-xy) weiter!

Wird zu:

Bitte lesen Sie <a href="..." title="Titel der Seite XY">hier</a> weiter!

Mittels JavaScript wird aus dem title dann ein Tooltip erstellt.

Damit wird die Anforderung an "self speaking links" automatisch optimiert:

image

(Natürlich muss der Tooltip zugänglich programmiert sein, aber das wir dann Severin's Aufgabe sein.)

Add additional attributes to HTML elements

Wie hier bereits angetönt, wäre es sinnvoll, einzelnen Elementen per Markdown weitere Attribute hinzufügen zu können, etwa CSS-Klassen.

Für interne Links würde dann z.B. .page vergeben, für Code-Beispiele ein .code, für Grafiken ein .image, etc.

Momentan sieht das noch so aus:

{.page title="Hiding elements from all devices"}

Screenshot:

image

Site Search 360 setup fine-tuning

Once the pages structure is stable, the Site Search 360 setup needs to be fine-tuned in order to have relevant search suggestions and results.

Also take into account this preliminary feedback: #37 (comment)

Netlify setup

@jmuheim, could you create an "official" Netlify account and give it read access to this repository?

In the long term we'll need to add the proper domain there, too (if we keep using Netlify).

Optimise code examples

The Codepen links need to be working.

Display of HTML, CSS and JS isn’t necessary for the time being (it could be disturbing especially for screen reader users, if not done correctly, and I will have to investigate this a little deeper to know how to do it well).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.