acbgbca / minecraft-bedrock-docker Goto Github PK

readme.md file needs to be completed. At a minimum it needs to contain:

• Link to Docker hub
• Description of project
• Steps to run
• Examples for docker run and docker-compose

Containers shouldn't run as root for security reasons. The container needs to be updated to run by non-root by default, and to let the user customise which user the container runs as.

Because the setting files sit directly in the Minecraft directory it isn't easy to mount them at run time. Instead we need to add the ability to pass in environment variables which will over-ride the settings

Things to look at:
- JQ - https://stedolan.github.io/jq/

Update:
After some thought I've changed my mind. Updating the files on the fly with the environment variables could lead to issues.

Instead, I am going to move the config to a separate location, and use symbolic links to put them in the minecraft directory. Makes it easier for the files to be edited and backed up

Add configuration for Github actions

Create an Alpine linux version as it should be much smaller in size than Ubuntu

This will mean we'll need distro specific tagging to identity the differences

set-output is now deprecated: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Another method will need to be found to pass values to subsequent stages.

To avoid premature upgrades, there should be additional latest tags for each version. E.g.

• 1.18
• 1.19
  etc

That will mean major version upgrades won't happen until someone is ready

We need to test start the container prior to pushing the image to ensure that it does start correctly, and to ensure there have been no dependency changes upstream.

The Dockerfile should be updated to build in separate stages. That will help reduce build times, and also try to keep the image as small as possible.

The current version does not start. It appears to require a newer glibc version

We should add a healthcheck to the container to verify that it is working.

We should also be able to use that to verify that the container works after a release.

A check needs to be added on start to verify that the user accepts the Minecraft EULA: https://www.minecraft.net/en-us/terms

Steps:

• Add a check in start.sh to verify a EULA environment variable is set to true

The following error is occurring on start up

./bedrock_server: error while loading shared libraries: libcurl.so.4: cannot open shared object file: No such file or directory