Git Product home page Git Product logo

rewind's Introduction

rewind's People

Contributors

abstrakt8 avatar vince7778 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

rewind's Issues

Installing the app doesn't work.

When I tried to install Review it said it can't install the uninstall.exe file, I figured I would do fine without it so I just skipped it and installed the rest but it turns out the program didn't install at all anywhere. It might have to do with the fact that I changed install directory cause I didn't want it on my C: drive but even trying to install there it breaks. (I don't remember the default path)

  • OS: Windows 10
  • Version 10.0.19044 Build 19044

error2
error1

combo-break where there is none

When you press the second button (double tap) to hold the slider, while there is another object under the slider, premature pressing and a combo break are counted. In Osu, this does not count as a combo break!

0.mp4

Drag and drop support

Describe the solution you'd like
Drop the replay in the window and open it

Additional context (optional)
Also currently, the file picker always starts at the replay folder, which I think only makes sense when being opened for the first time. It should remember the last chosen file's path

If the beatmap is not present, Rewind gets stuck trying to load the replay.

Describe the bug
If the beatmap is not present, Rewind gets stuck trying to load the replay and won't notify the user about it.

To Reproduce (optional)
Steps to reproduce the behavior:

  1. Record a replay.
  2. Delete the beatmap for that replay.
  3. Try to open the replay.

Expected behavior
The user should get notifed about the beatmap not being present (same as osu!).

Desktop (please complete the following information):

  • OS: Windows 10 Pro
  • Version: 22H2 (build 19045.3086)

Custom songs folder

Describe the solution you'd like
I use custom folder for maps and seems like program cant see them.

Performance

Describe the solution you'd like
Is there a way to optimize it in such a way that even low-end or even middle-end laptops can run it smoothly?

Additional context (optional)
On the normal or the default settings, the app, when playing a replay runs at a constant 2FPS
image

After some setting changes, the highest fps I could get was 22FPS. (the 0-60fps here is because of the break. and we all know that there are no objects in a break therefore my fps wont drop).
image

So, is there a way? or do i just have to suffer and wait until I get a better laptop.

Add Spinner

Ability to see The Spinner

I want to be able to see the Spinner (how many points did I/Someone in the replay get and RPM (optional)), but Rewind don't show that. So can you add spinner in?

Rewind:
Rewind Screenshot 2023-01-11T16_50_02 728Z

osu!:
screenshot013

Graph height is too big, reaching into gameplay area

Describe the bug
The timeline graph can reach outside the timeline section, and straight into the gameplay area. Not sure if intended or not, but this looks off.

To Reproduce (optional)
Steps to reproduce the behavior:

  1. Open some map (with clear seperated calm and intense section if you want to see clearly)
  2. Look at the timeline graph

Expected behavior
Graph height should stay inside timeline area, or have some fixed height.

Screenshots
image

Desktop (please complete the following information):
This shouldn't really matter but...

  • OS: Ubuntu (GNOME)
  • Version: 21.04, GNOME 3.38

Additional context

Please also provide the following if they are mentioned and related:

  • Beatmap: Playing with Ruby [Extra]
  • Replay
  • Skin

Relax mod (RX) support

Rewind treats relax replays as if relax wasn't on. What I mean by that is Rewind shows the replay as all notes being missed because there is no physical tapping.

I have a problem with rewind when using "#" character on a skin name some of the gameplay element on the skin will not load.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce (optional)
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context

Please also provide the following if they are mentioned and related:

  • Beatmap
  • Replay
  • Skin

Replays folder should not be a requirement to a valid osu! directory

Describe the bug
Hey, I found a minor bug/inconvenience while setting it up for the first time. So Ive actually never saved a replay before (I know, right), and my osu! folder did not have a "Replays" folder. I guess the Replays folder is not created upon installing osu!, but upon exporting a replay. This meant that when I went to select my osu! folder, it would check to see if the selected folder is actually the osu! folder by checking for select files in its contents, but of course it would not find the "Replays" folder because it did not exist. This gave the error message "Does not look like a valid osu! direcory!" I fixed it just by exporting a random replay, which created the file in the osu! directory. Not a big deal at all, just a little inconvenient and unintuitive.

To Reproduce (optional)
Steps to reproduce the behavior:

  1. Fresh install of osu! (or just delete the "Replays" folder)
  2. Select the osu! directory in Rewind
  3. See Error

Expected behavior
Be able to select the osu! folder, even if the Replays folder does not exist, as long as the other files do exist.

Screenshots
image
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Version: 10.0.19043 Build 19043

Additional context
Not sure if this is relevant, but I did copy my entire osu! folder over from a different hard drive a couple weeks ago. Im sure I copied the entire folder, I just have never exported a replay since I first installed osu! BTW, thanks for making this, this is awesome.

Skins with an "#" in their name seem to freeze the replay player

Describe the bug:
When selecting a skin with an hashtag in its name, the replay player freeze while the song continue playing. Changing back to a working skin keep the replay frozen but when closed and reopened, the replay player start working again,

Screenshot:
image
Here the skins with hashtags don't work while others special caracters like the "⟦" below don't cause any issue. Also, the renamed "notMiku" without the hashtag is working as intended.

Desktop:

  • OS: Windows 10 family build 19045.2728

I'm using the new 0.2.0 version, I didn't have this bug with the old one.

Incorrect display of numbers

The skin in the following screenshot is using default numbers instead of its own:
image

This is due to the fact that in the default, score, combo are inside of their own folders and are accessed in the skin.ini file with the following entries under [Fonts]

HitCirclePrefix: Assets/default/default
ScorePrefix: Assets/score/score
ComboPrefix: Assets/combo/score

e.g. in the skin folder the score numbers would be found in Assets/score/. Please add support for searching for files inside of folders as provided in the skin.ini

AUR package?

Thanks for the good work!
Are you considering to publish this in Arch User Repository?
It would make the installation process on Arch systems a lot more easy, even if the AppImage is quite nice already

Error Extracting the File

Describe the bug
I just downloaded it and it aborts the installation.
To Reproduce (optional)
Steps to reproduce the behavior:
I used this before i deleted my Visual C++ Redistributable's and it worked
i Think that might be one of the reasons why, i download a Visual C++ and it didn't work.
There's probably an another problem that's causing this.

Expected behavior
To use the rewind software as normal

Screenshots
Screenshot_14

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Version [e.g. 7]

Additional context

Please also provide the following if they are mentioned and related:

  • Beatmap
  • Replay
  • Skin

Incorrect replay playback

Describe the bug
Rewind makes sliderbreak even if there is no sliderbreak.

To Reproduce (optional)

  1. Go to map https://osu.ppy.sh/beatmaps/1029307
  2. Download Bubbleman replay
  3. At 505 combo rewind shows sliderbreak, but there is no sliderbreak on the play
  4. Replay ends with 1800~ combo but in the game it's FC with 2300+

Expected behavior
There should not be any sliderbreaks in play. You can even see that player taps slider in the correct timing but still gets sliderbreak in Rewind.

Desktop (please complete the following information):

  • OS: Windows
  • Version 10

Please also provide the following if they are mentioned and related:
Map: https://osu.ppy.sh/beatmapsets/482382#osu/1029307
Bubbleman's replay (https://osu.ppy.sh/scores/osu/3841640739/download)
Default Rewind skin

Out of proportion images

Reported by khz

Needs fix soon (but also consider xOffset, yOffset that is specified in the .osu file)

Loading forever

Describe the bug
When I try to load the replay, the program just loads it infinitely

To Reproduce (optional)
Steps to reproduce the behavior:

  1. Load a replay
  2. Infinite loading

Expected behavior
Open a replay

Screenshots

Desktop (please complete the following information):

  • OS: Windows
  • Version 11 22H2

Additional context

Please also provide the following if they are mentioned and related:

Cant't set a directory

I downloaded lastest non beta, and was greeted with thisn
image
but when i got to osu folder it shows this
image

help pls

Relax mode support?

Would like to see relax mode support. It could be really helpful for any relax player.

File picker button label is incorrect on GTK/GNOME

Describe the bug
When choosing file/folder in GNOME/GTK, button labels are not set to proper value.

To Reproduce (optional)
Steps to reproduce the behavior:

  1. Open any file picker
  2. Look at the buttons

Expected behavior
Correct labels, like "OK" and "Cancel"

Screenshots
image

Desktop (please complete the following information):

  • OS: Ubuntu (GNOME)
  • Version 21.04, GNOME 3.38.4

Additional context

Keyboard Pause Button Bug

When a manual pause button on my keyboard is pressed, the audio pauses, but the video itself does not

Steps to reproduce the behavior:

  1. Load a Replay
  2. Press pause button on keyboard
  • OS: Windows 10 Pro
  • Version 0.1.0

Additional context
My pause button on my keyboard is activated via FN+I rather than a standalone button, though I don't see why this would make any difference.

I encountered this bug while trying to stop spotify from playing, so that may have some relevance.

Customisable click crosses (analysis cursor)

I think it would be a good idea to allow some sort of customisation for the "click" crosses (with the analysis cursor), since I often confuse it with the "miss" cross. (especially the orange one)

image

Maybe its just me, just a suggestion. Appreciate your amazing work on this tool!

Replay fails to load

Describe the bug
Any replay on the beatmap Zettai Tokken Shuchou Shimasu! Hoshi Syoko Solo Remix loads endlessly. Tested only on the "Koume's Extra" and "Karia's Extra" difficulties.

Expected behavior
The replay should finish loading.

Desktop

  • OS: Windows 10 Pro
  • Version: 2004 (build 19041.329)

Additional context
This bug was bugging me a bit (haha), so I decided to investigate a little. The developer console reports some 404 Not Found errors on requests made to the internal API of Rewind when attempting to load the replay. The requests seem to contain a trailing space character (%20) at the end of the directory name of the beatmap.

To mitigate this issue, I used Fiddler to redirect the requests to an address without the trailing space, although it cannot be done for the background image request as it seems to be handled internally by the API itself (which returns a 500 Internal Server Error, presumably for the same reason as the other errors).

A quick and dirty fix could be to trim the string before appending it to the URL, but I wonder why this doesn't happen on the other beatmaps.

Extra
Although this bug seems to present itself with any replay I tested so far, I have attached one in case it is necessary:
Ratchy - Syoko Hoshi (CV Satsumi Matsuda) - Zettai Tokken Shuchou Shimasu! Hoshi Syoko Solo Remix [Koume's Extra] (2022-02-27) Osu.zip

macOS support?

I'm playing osu through crossover under macOS.
This might be a bad idea but I wish I could use it on macOS 🥹

RX support

All the RX replays are not being displayed correctly, the circles are all counted as misses in Rewind even if they are counted as hits in game

osu!lazer support

Describe the solution you'd like
Support and instruction how to use rewind with osu!lazer.

Additional context (optional)
Osu!lazer has different folder structure and database. It uses realm (file client.realm)
All beatmaps and replays are stored in file /.local/share/osu/files/ in two level of folders.

~/.local/share/osu/files$ ls
0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f
~/.local/share/osu/files/0$ ls
00  01  02  03  04  05  06  07  08  09  0a  0b  0c  0d  0e  0f
~/.local/share/osu/files/0/00$ ls
0006756adb51dfcd11c5df99db8f5ab07b4064e8af89640c0df4d0c60bf2ef2b  0081d94ec7c65521eb58659eaba58cbb18b61e1edb08810d7aa2cda542059d8d
000e2a7d234652224dcb1a031fe1b6b27dbfdb18107f76e3979190b1f92a03a6
[...]
00fced607a1aa3c9fd45c7c4b17b5af21ff2e11f2d80ab96a1ef9e79f5446621

These weird files are replays, images, songs, etc.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.