absmach / senml Goto Github PK

According to the RFC 8428 spec, it seems to be valid to not have a Value in the Base Record of a JSON SenML record. Please see Section 5.1.7, first example. However, the Mainflux SenML transformer requires a Value field to be present in each SenML Record.

Meaning the following SenML is invalid according to Mainflux:

[
  {
    "bn": "urn:dev:ow:10e2073a01080063:",
    "bt": 1648560975
  },
  {
    "n": "temperature",
    "u": "Cel",
    "v": 18.3
  },
  {
    "n": "humidity",
    "u": "%RH",
    "v": 42
  }
]

But this is valid (first and second Records are merged):

[
  {
    "bn": "urn:dev:ow:10e2073a01080063:",
    "bt": 1648560975,
    "n": "temperature",
    "u": "Cel",
    "v": 18.3
  },
  {
    "n": "humidity",
    "u": "%RH",
    "v": 42
  }
]

You can see in the following Validate function that an ErrNoValues is thrown if a Value is not present:
https://github.com/mainflux/senml/blob/78a09af66021636e0974f768118d54a9674ed7ff/senml.go#L230-L232

Can you update the Mainflux SenML Validator to be in line with the RFC 8428 spec?

Hello, as I see the SenML use ' []senml.Record', not use 'senml.Pack', I found the definition of senml.Pack below:

// Pack consists of SenML records array.
type Pack struct {
XMLName *bool json:"_,omitempty" xml:"sensml"
Xmlns string json:"_,omitempty" xml:"xmlns,attr"
Records []Record xml:"senml"
}
Why not use this struct's json-Marshal?