abs-tudelft / fletcherfiltering Goto Github PK

Remove all mentions of nullable from the data processing code. Should be split up in a bool and the value in the input and output.

The other option is implementing all the operators on the nullable struct. Although strings will keep being difficult.

Create some input AST documentation.

Not sure if I should just filter all records with LOW dvalids anywhere in the row.

I will release new incompatible version of horast soon. I'm using semver but I noticed in your requirements you have plain horast written, so your code will break unless you restrict the required version to <0.4.0, or alternatively, also update transpyle. Current transpyle depends on <0.4.0 but unfortunately also will break because it also has plain horast written in reqs. Although I'm using semver in my projects pretty consistently, I haven't been very good at specifying requirements in them until now ;) I'll be fixing that, but past versions will suffer...

Related to #1

For example the port name in_data.id results in the main data part to be suffixed with _TID instead of _TDATA. I can't find anything in the documentation about reserved names. And because renaming does not work currently, there is no fix.

HLS bug:

#pragma HLS INTERFACE axis port=in_data.int1 name=i_int1

The name gets ignored here, the resulting RTL ports are still called in_data_int1_V_TDATA and not i_int1_TDATA.

This is also broken for ap_fifo. The documentation does not mention anything about unsupported combinations: https://japan.xilinx.com/html_docs/xilinx2017_4/sdaccel_doc/jit1504034365862.html

Maybe due to a new pyarrow version.