abs-tudelft / cmake-modules Goto Github PK

We should add a check here which skips absolute paths.

target_include_directories can not be used on an ALIAS target.

This happens if target name matches alias name (no :: in name). We have to make sure that the alias is different from the target or skip alias generation if there is no :: in the target name.

These lines in CompileUnits/CompileUnits.cmake

FetchContent_Declare(googletest
  GIT_REPOSITORY  https://github.com/google/googletest.git
  GIT_TAG         master
)

is now broken due to tag name being changed in googletest to main.

See here:
google/googletest#3663

I got this error when trying to build the fletcher project from source. It worked after I manually changed the tag.

This seems to be missing.

Currently, when running cmake with -DBUILD_TESTS=ON, it causes all compile units to build tests, including projects that you e.g. fetchcontent into your project.
This is undesirable, because when running make all dependency tests are compiled, and when running make test it runs all tests of dependencies.

Is it possible to specify for which compile unit to build the tests?
Or perhaps there is a way to only enable tests for compile units that were added in the current CMakeLists.txt,
perhaps with a different value for -DBUILD_TESTS=LOCAL or something?

When building compile units, at update step benchmark-populate fails producing the following error:
[ 11%] Performing update step for 'benchmark-populate'
fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'
error: pathspec 'master' did not match any file(s) known to git.
CMake Error at /home/yyunon/thesis_journals/resources/tpc-spark-fletcher/fletcher/runtime/cpp/build/_deps/benchmark-subbuild/benchmark-populate-prefix/tmp/benchmark-populate-gitupdate.cmake:144 (message):
Failed to checkout tag: 'master'