Hi

Previously I am using API to fetch prayer times, because I thought they are always changing. But, after trying your module, the result is accurate.

Would you like to point the article/source of your prayer times algorithm calculation? In short, aren't they always changing every year?

Thank you.

For example, if Ramadan is 30 days long and in pyIslam is 29, if we use the correction value -1, the HijriDate will be 1 Shawwal instead of 30 Ramadan!

Hi.

I used to use pyIslam before. Nowadays I am working with Rust. Having used Rust Islamic library, I got some errors and less precision. So I thought it's better to have pyIslam ported to Rust.

Upon porting. I find some difficulties, namely finding its return type and parameters type. Also, some class parameters in pyislam accept different types, such as MethodInfo or integer. This leads me to change the API but keep the logic intact.

To make porting easier, I made some changes to pyIslam:

• add unit-test for Hijri, salah, qiblah, etc
• add Github action for CI

Also, I had some questions:

• Is there any longer variable name in the baselib.py, instead of using a, x, c (single letter)? longer variable names make it easier to read and maintain
• I find the wrong calculation in hijri.py, is it?
• I think is_last is never used ?

If you accept the changes, I would also like to add release to PyPi step in the release.yml

This is my Rust port islam. It has the exact same result in its unit-test

how can i use this in my app

The following inputs:

def test_praytimes_amsterdam():
    # Tested against
    # http://api.aladhan.com/v1/calendarByCity?city=Amsterdam&country=Netherlands&method=3&school=0&month=05&year=2022
    latitude = 52.3745403
    longitude = 4.89797551
    timezone = 2  # GMT+2

    fajr_isha_method = 2  # Muslim World League
    asr_fiqh = 1  # Shafii
    prayer_conf = PrayerConf(longitude, latitude, timezone, fajr_isha_method, asr_fiqh)
    prayer_time = Prayer(prayer_conf, date(2022, 5, 19))

    assert str(prayer_time.fajr_time()) == "03:14:00"
    assert str(prayer_time.sherook_time()) == "05:39:00"
    assert str(prayer_time.dohr_time()) == "13:37:00"
    assert str(prayer_time.asr_time()) == "17:52:00"
    assert str(prayer_time.maghreb_time()) == "21:35:00"
    assert str(prayer_time.ishaa_time()) == "23:52:00"

will result in a ValueError: math domain error inside praytimes@_get_time_for_angle when trying to evaluate sqrt(-s * s + 1) because the value of -s * s + 1 is negative.

I wanted to submit a patch instead of reporting the issue but I have no idea what all the variables represent :(

Hi

I find this module is really helpful. I've checked the prayer time is accurate (compared to other website).

Would you like to put this in PyPi?

Thank you for pyislam.

In the examples folder, praytimes.py is trying to import a variable named "LIST_FAJR_ISHA_METHODS" from pyIslam.praytimes, that variable does not exist in that file.

Hi, Abdelhak.

I plan to refactor my Rust port. Primarily the baselib.
I am having a hard time understanding the equation because of single variable names such:

• pyIslam/pyIslam/baselib.py

  Line 24 in eb5cd7a

  n = jd - 2451544.5

Are you able to rename those single-char names to a more descriptive name?

def equation_of_time(jd):
    '''Get equation of time'''
    n = jd - 2451544.5
    g = 357.528 + 0.9856003 * n
    c = 1.9148 * dsin(g) + 0.02 * dsin(2 * g) + 0.0003 * dsin(3 * g)
    lamda = 280.47 + 0.9856003 * n + c
    r = (-2.468 * dsin(2 * lamda)
         + 0.053 * dsin(4 * lamda)
         + 0.0014 * dsin(6 * lamda))
    return (c + r) * 4

jd would be julian_day, but I have no clue about n, g, c, etc.
Is the source also using a single char name?

The current method taken from http://www.icoproject.org/pdf/2001_conv.pdf
This method give always a fixed 30 days value for the Ramadan month!! 👎

Is there fajr isha method of the UAE?

Hi, abougouffa.

I love this library, and I plan to port it to Rust.
Unfortunately, two things that make me slower are the type and unit test.
The most important one is the latter, I can confidently port each function and assess its correctness if pyislam had more unit tests.

Is it okay if I add the unit test and Github action CI to the repo?

last_ramadan_day = HijriDate(YYYY, MM, 30)

and the MM in the given year YYYY is 29 days long, this should raise an ValueError exception!

Hello i am getting this error , here's my code :
pt = Prayer(PrayerConf(location.longitude, location.latitude, timezone, school, juristic), date.today())

Thank you for your help

The current method works on normal zones, for zones higher than 48.5N or 48.5S, there is no real night in some periods of the year, hence, the calculation of Fajr and Ishaa is not possible using the same criterions.

See Muneer, Tariq, The Islamic Prayer Times - Computational Philosophy with Particular Reference to the Lack of Twilight Cessation at Higher Latitudes