Git Product home page Git Product logo

accu-2017-elm-app's People

Contributors

rob-smallshire avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

rob-smallshire

accu-2017-elm-app's Issues

Page loads offset to the right

it seems as if the page is shifted to the right when it gets loaded. I have to manually pull it to the left. This is weird...

Navigating from and to app results in javascript errors

If you e.g. click on a link in the footer to go to sixty-north.com and then navigate back to the app using the back arrow, the app stops working properly (i.e. things are displayed that should be) and you see errors like this in the console:

Uncaught TypeError: Cannot read property 'childNodes' of undefined
    at addDomNodesHelp (app.js:15936)
    at addDomNodesHelp (app.js:15944)
    at addDomNodesHelp (app.js:15944)
    at addDomNodesHelp (app.js:15964)
    at addDomNodesHelp (app.js:15889)
    at addDomNodesHelp (app.js:15944)
    at addDomNodesHelp (app.js:15944)
    at addDomNodes (app.js:15863)
    at applyPatches (app.js:15992)
    at updateIfNeeded (app.js:16332)

This might have something to do with not waiting for DOM elements to appears. Perhaps we just need a timeout.

Add footer

This should contain copyright info, feedback links, etc.

Card clicks handled multiple times

The way we handle clicks on the proposal cards is causing multiple events to propagate. I think the issue is that we handle a) clicks on the card itself and b) clicks on individual links. I guess it's pretty obvious in retrospect. A way to see this is to click on a presenter's name. This will correctly take you to the presenter's view, but if you back-arrow through history you'll see that we first pass through the session view (assuming you're on a branch with presenter view support).

I'm not sure what the best solution is. One is to stop responding to clicks on the card as a whole; perhaps just title clicks should be enough. Another is to somehow prevent event propagation to the card when links are clicked; not sure if this is even possible.

Need to transfer this code to an ACCU specific owner

We need to think about and plan how to transfer ownership of the repository to ACCUConf. I suspect GitHub can allow the repository to have an owner but set up a team so the current owners retain all management rights on the repository.

Also need to think about setting up conference.accu.org to be able to serve the built application โ€“ testconference.accu.org in the first instance.

Consider header links rather than tabs

We currently use tabs to separate session views into days. Header links would probably be better because:

  1. The save display space
  2. They're probably a bit simpler

This will involve setting up routing for the various days, but it also means that we can remove the "selectedTab" member from the model.

Improve delineation of the cards

Right now it's not always obvious where the cards end, due a lot to the cards and background both being white. Problems include:

  • The orange action box of a proposal card appears more closely associated with the title of the card below it than its own title.
  • Similarly, the distance between the card title and the action box makes it hard to visually associate them.

Need to get the sponsor logos into the users view

With the webpage, we have the sponsor logos on the left, other stuff on the right and content central. Whilst using the webpage template may be a bad idea per se, it would be good to get consistent styling and have the sponsor logos somewhere on the schedule Web application.

Access presenter blurb

There doesn't seem to be a way of accessing presenter blurb. At least using Chrome on Debian Sid the names are not links.

Handle AsciiDoc, not just Markdown

We currently treat the proposal descriptions as Markdown, and this kinda-sorta works. However, it's apparently in AsciiDoc. It's somewhat amazing that the markdown parser does as good a job as it does on the current text!

Anyhow, see if there's anything to be done about this.

Allow clicking on card titles

Clicking the title seems to be the intuitive way (based on observing users) to go to the view for that card, i.e. the job of the "details" button right now. We could easily keep both, but we definitely need to support title clicks.

Licence statement in README

Although the GitHub control line says MIT, and there is a LICENSE.txt file, it is not immediately clear to someone alighting on the page what the licence is for this software โ€“ I think GitHub could do their licence display thing better. Perhaps adding a section in the README with a licence icon so that it is "hit people over the head" obvious might be helpful?

Or maybe I am worrying over nothing.

Wrong days

Conference is Wednesday, Thursday, Friday, Saturday. Tuesday is workshops day. Currently the application gives the conference as Tuesday, Wednesday, Thursday, Friday.

Improve layout of cards

It would be nice (critical?) to have a layout that reflected the room and time assignments. So a grid with rooms at the top and times down the side. It would be nice if we could apply this to both day views and agenda views, probably search views as well.

Plenary sessions not present

The keynotes, the lightning talks, and the ACCU AGM are not listed, only the parallel sessions are present. This may be a development choice for this stage, and that is fine. Going forward though, it would be good to have them.

Trying to initialize the `ACCUSchedule` module with an unexpected flag.

When I follow the installation instruction I get this error when I connect to the running application.

Oops! Something went wrong when starting your Elm program.

Trying to initialize the `ACCUSchedule` module with an unexpected flag.
I tried to convert it to an Elm value, but ran into this problem:

Expecting a String at _.apiBaseUrl but instead got: undefined

Display session times

We need to first see if this is available from the server. It would be nice if we could use that as the "source of truth" for the time-session correspondence. If not, we might just need to hard-code it or pass it in via flags.

Account for "quickie sessions" in view

Right now we don't show that information anywhere. We should probably show it on the proposal card, and it might be nice if we could group the cards in a session together (should be trivial).

Means to reload schedule data

We need a button or something to re-fetch schedule data from the server. A button somewhere should suffice.

Ultimately we may want to poll the server to do reloads automatically, but at first this button should be enough.

TBC entry causes misalignment

The five columns of the schedule represent the rooms the sessions are in. Each session blurb has the data, but any TBC entry causes no column and so introduces a "misalignment".

Weird scrolling issue on mobile safari

On a proposal view with a long abstract and zoomed in such that the entire abstract can't be viewed, Safari on the iphone shows strange scrolling behavior. It seems to "lock" to a scroll position and prevent scrolling down or up without strenuous effort. Needs verification/replication.

I tried to replicate this on mobile Chrome, but things worked fine there.

Sort out deployment

Right now the app is hard-coded to fetch data from a test server. Obviously this needs to be changed, and the data source should probably be configurable somehow between production and development.

Depending on how we decide to deploy the app relative to the standard ACCU Conf website (which will be serving up JSON schedule data), we will need to look into handling CORS stuff.

No link specific pointer

Using Chrome on Debian Sid, I see the arrow pointer when not over text and the I pointer over text, there is no change to the hand pointer over links. The lack of feedback makes it difficult to know when hovering over a link that can be clicked. The consequence is that it is not totally clear that the name of a session in the schedule is a link to the blurb.

"personal schedule" view

We need a view where people can see their list of "starred" sessions. This should probably have a convenient link in the header (or drawer if we go that way).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.