abiaad / paaimageview Goto Github PK

A completion handler with success/error of the operation inside setImageURL method could be useful in order to place another (local) image if download fails or url is not valid.
It should be very easy to integrate if you have used AFNetworking.
Great class man!

It returns:
[!] Unable to find a specification for PAAImageView

Fixing it is just a matter of converting a bunch of the Floats to CGFloat in the circlepath and radius definitions.

Sometimes the image view shows other images from reused cells in UITableView while loading the appropriate image from the server instead of showing a placeholder. Quite weird.

- (UIImage *)getImageForURL:(NSURL *)URL
{
NSString *fileExtension = [URL pathExtension];//[[URL componentsSeparatedByString:@"."] lastObject];
NSString *path = [self.cachePath stringByAppendingPathComponent:[NSString stringWithFormat:@"%u.%@", URL.hash, fileExtension]];
if([self.fileManager fileExistsAtPath:path])
{
    return [UIImage imageWithData:[NSData dataWithContentsOfFile:path]];
}
return nil;
}

I think where you are loading the NSData for images saved in cache, there is a memory leak.

I replaced this line :
return [UIImage imageWithData:[NSData dataWithContentsOfFile:path]];

with This:
return [UIImage imageWithContentsOfFile:path];

and noticed quite some improvement. Have a look.

Thanks.

Great stuff !

Does this include AFNetworkings AFAmazonS3Manager? Can we use this to download from s3?

I’ve recently added PAImageView to the CocoaPods package manager repo.

CocoaPods is a tool for managing dependencies for OS X and iOS Xcode projects and provides a central repository for iOS/OS X libraries. This makes adding libraries to a project and updating them extremely easy and it will help users to resolve dependencies of the libraries they use.

However, PAImageView doesn't have any version tags. I’ve added the current HEAD as version 0.0.1, but a version tag will make dependency resolution much easier.

Semantic version tags (instead of plain commit hashes/revisions) allow for resolution of cross-dependencies.

In case you didn’t know this yet; you can tag the current HEAD as, for instance, version 1.0.0, like so:

$ git tag -a 1.0.0 -m "Tag release 1.0.0"
$ git push --tags

https://github.com/liyoro/LIPAImageView