Git Product home page Git Product logo

abhi9720 / bankingportal-api Goto Github PK

View Code? Open in Web Editor NEW
89.0 5.0 72.0 37.59 MB

The banking portal API provides secure and efficient endpoints for managing user accounts, transactions, and fund transfers, offering essential banking functionalities with robust error handling and authentication.

License: MIT License

Java 99.94% Dockerfile 0.06%
spring-boot spring-security spring-security-jwt banking-api banking-applications banking-management banking-system banking-transactions jwt-authentication maven

bankingportal-api's Introduction

π‡πžπ₯π₯𝐨 𝐭𝐑𝐞𝐫𝐞, 𝐟𝐞π₯π₯𝐨𝐰 <πšπšŽπšŸπšŽπš•πš˜πš™πšŽπš›πšœ/>!

β€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Žβ€Ž Typing SVG

Hello, I am Abhishek Tiwari a Final year undergraduate from Nit Manipur.
a passionate self-learner and a Web Developer( MERN ) Β Β ,

Thought : "Life is full of choices…choose wisely!”

About Me

Unicorn
  • πŸ”­ I’m currently working on Facebook clone

  • 🌱 I’m currently learning Reactjs

  • πŸ‘― I’m looking to collaborate on Facebook Clone

  • πŸ’¬ Ask me about Mern Stack

A little more about me

const Abhishek = {
  pronouns: "He" | "Him",
  code: ["Javascript", "Nodejs","React", "Java", "Python"],
  askMeAbout: ["web dev", "Automation & Scrapping", "Programming"],
  technologies: {
      frontend: ["HTML", "CSS", "JS", "Bootstrap","React.js"],
      backend: ["Nodejs", "JS"],
  }
}

πŸ”Ž Search me on:

abhi9720 100008338115771 ishutiwari75 abhi9720 abhi9720 abhi9720

πŸ’» Tech Stack:

C C++ CSS3 HTML5 Java JavaScript Netlify Heroku Vercel Express.js NPM React Redux Socket.io MySQL MongoDB

πŸ“Š GitHub Stats:



πŸ† GitHub Trophies

✍️ Random Dev Quote

πŸ˜‚ Random Dev Meme


bankingportal-api's People

Contributors

abhi9720 avatar amrelsayyad avatar bakhshimoeez avatar pg312 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

bankingportal-api's Issues

Add Google java format

Make it mandatory for all contributors to install google java format in their IDEs to format code.

Use enum for messages

I can see hardcoded api messages in controller, use a enum to define all messages to manage easily.

Add methods to reset PIN and password

Is your feature request related to a problem? Please describe.
If a user forgets PIN or Password there are no ways to recover.

Describe the solution you'd like
Implement methods to reset PIN or password, e.g., via email.

Add support for Lombok dependency

I can see a lot setter and getter methods and autowired annotations on service layer. To look more clear and readable we can add lombok support in backend system.

Swagger UI for Documentation is comprehensible for both developers and non-developers like clients or project managers.

Is your feature request related to a problem? Please describe.
For developers and non developers that might take interest in this project might need swagger UI for easy documentation and comprehension

Describe the solution you'd like
Implement swagger UI. I mean the Open API version

Describe alternatives you've considered
Postman is an alternative sure. But it does not make documentation as easy and comprehensible as swagger UI

Additional context
I want to ask if I can go ahead with implementing swagger with the app

Make controller light weight.

Use controller for request and response.

I can see in controller there is if else being used, please move all logic to service layer instead controller e-g: controller used for user authentication.

Enhance Test Coverage in Test Suite

To ensure the robustness and reliability of our application, I propose enhancing the test coverage in our test suite. This will help us identify potential issues early and maintain high code quality. Specifically, we should:

  1. Identify Critical Areas: Focus on areas with the highest impact on functionality.
  2. Increase Unit Tests: Add more unit tests to cover edge cases and different scenarios.
  3. Follow TDD: Implement tests before adding any feature.

Bug: Angular HttpClient Fails to Parse OTP Response

Is your feature request related to a problem? Please describe.
The Angular HttpClient currently fails to parse the OTP response correctly when it is returned as plain text. This leads to parsing errors and affects the functionality of handling OTP responses in our application.

Describe the solution you'd like
I would like to modify the OTP response to be returned as JSON format instead of plain text.

Describe alternatives you've considered
One alternative considered was to continue using plain text but with additional parsing logic on the client-side. However, this approach adds complexity and potential maintenance issues compared to directly returning JSON.

Additional context
This issue impacts the user experience by hindering the accurate processing of OTP responses in our Angular application. By implementing this change, we aim to improve the reliability and efficiency of OTP handling.

Add Comprehensive Docstrings to Codebase

Is your feature request related to a problem? Please describe.
Currently, the codebase lacks comprehensive docstrings, making it difficult for developers to understand the purpose and functionality of various methods and classes. This can lead to confusion and increased time spent on code review and debugging.

Describe the solution you'd like
I propose adding detailed docstrings to all methods and classes in the codebase. These docstrings should follow a consistent format and provide clear explanations of the parameters, return values, and any exceptions raised.

Describe alternatives you've considered
Creating a separate documentation file is an alternative solution, but it might not be as effective as embedding docstrings directly within the code. Docstrings are more accessible to developers, making it easier for them to understand and maintain the code.

Additional context
Adding comprehensive docstrings will improve code readability and maintainability, making it easier for both current and future developers to work with the codebase.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.