aaronkjones / rpi-k8s-node-prep Goto Github PK

Switch case input to simple y/n instead of using default.

https://github.com/aaronkjones/rpi-k8s-node-prep/blob/master/prep.sh#L14

However...

pi@raspberrypi:~ $ uname -a
Linux raspberrypi 4.14.50-v7+ #1122 SMP Tue Jun 19 12:26:26 BST 2018 armv7l GNU/Linux

pi@raspberrypi:~ $ cat /etc/os-release | grep raspbian;
ID=raspbian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

pi@raspberrypi:~ $ echo "exit code zero would mean success-> $?"
exit code zero would mean success-> 0

Running your script with #!/bin/bash -x shows:

+ uname -a
+ grep hypriot
+ uname -a
+ grep raspbian
+ [[ '' == \r\a\s\p\b\i\a\n ]]
+ [[ '' == \h\y\p\r\i\o\t ]]
+ echo 'OS type not known'
OS type not known
+ exit 1

From your README:

curl -sL https://raw.githubusercontent.com/aaronkjones/rpi-k8s-node-prep/master/prep.sh | sudo sh

but you use [[ in your script (and have a #!/bin/bash)

In the least, it should be piping to bash. But really, you shouldn't do that unless everything in the entire script is wrapped in function definitions and the main function is called at the very end to ensure that none of it runs until and unless all of it is downloaded.

For example, see the very end of the file at https://get.docker.com/ All the "actions" are in functions. The begining of the file has a bunch of "bare" code in the top scope, but it is just defining variables. Nothing gets executed until do_install.

apt-cache policy kubeadm | grep "Installed" | cut -d ":" -f 2 | awk '{$1=$1;print}'

If script is run more than once, cgroup settings are added multiple times to /boot/cmdline.txt

Actual output:
5 is currently installed.

Correct output:
18.09.03-0raspbian-stretch