aajfranklin / click-and-roll Goto Github PK

• Redesign for mobile first
• Add responsive design for tablets
• Add responsive changes for desktops
• Add responsive changes for large-scale desktops (4k)
• Darker motif
• Remove gif
• Add embedded video
• Install links with large icons
• Fix opacity in Firefox
• Update embedded video once 2.0.0 is live on any store
• Add privacy policy
• Update install links once live on new stores

• 2.0.0 release notes
• Links for other stores
• Requirements for other browsers

Link to firefox extension doesn't work

• Design tabs for switching between regular and postseason
• Update server to send postseason stats
• Show/hide correct table based on user's current choice
• Fix formatting of empty/short post-season careers
• Update cached stat version number

Reduce free up content thread by mapping stats to html table rows in background script on fetching the original data.

It takes multiple seconds to highlight names (up to 20 seconds sometimes).

This is with latest firefox (v75.0) on Mac

• Parameterise frame colours as CSS variables to create default palette
• Design frame dark mode colour palette
• Add toggle to popup
• If dark mode is on, add dark mode class when initialising frame
• Parameterise popup colours as CSS variables to create default palette
• Design popup dark mode colour palette
• Add dark mode class to popup on toggle

Automate copying and zipping of files for submission to web store.

Sync storage has a size limit. This could theoretically be exceeded over time if user visits enough sites that save settings.

If default setting is currently saved, update so only off setting is saved (i.e. add setting for sites that are toggled off, delete that setting when toggled back on, rather than updating it).

Points are probably the most important counting stat. They should be between min and FGM. hovering over the name and clicking outside the box to close the window is the perfect ux, but having to scroll horizontally causes some disruption to browsing activity. Might be nice if we could customize the categories we see too.

Thanks for the work you've put into this.

To ensure retired players' stats are not displayed in old formats because they are still cached.

Remove all star column from regular_seasons_per. Instead, fetch all star rows in server and use to add all star flag to regular season rows before sending to front-end.

Remove adding of all star column from cron.

Non-critical bug occurs when chrome devtools are open for the background script.

I have tested on a couple devices, all on Chrome. It seems that data stopped updating towards the end of the season:

Note 67 games played in the regular season rather than 72.

Names split over two lines sometimes don't highlight
Nicknames, initials not highlighting (Steph Curry, JJ Redick, P.J. Tucker examples)
What do the stars mean

Users noticed names within names getting highlighted, e.g. Mike Bloom within Mike Bloomberg. This is a simpler issue than player names within strings of 3+ names, e.g. a hypothetical Chris Mike Bloom, which this issue will not cover.

e.g. Lebron, Steph, Chuck etc.

Maybe allow users to add nicknames?

Only delete retired players from local storage if too many players, because retired players' stats cannot be out of date.

Minor gripe, but under FG%, the number shown is a decimal, leading percentages to look 100x lower than they actually are. I propose the stat table to show FG% as either true percentage, e.g., 53%, or as a fraction, .53. But not both. Hope this makes sense

Please add toggle to metric system

Add error message after certain time, explaining this is usually because too many requests have been made in a short time/hovered over many players' names in a short time.

• Research local and sync storage size limits
• Establish reasonable number of players to cache
• Cache player data + timestamp of fetch
• Check cache before making ajax request
• If not in cache: fetch, cache
• If in cache but >= 3hrs old: delete, fetch, cache
• If cache.length >= 50: 25 oldest viewed entries entry
• Smoke testing

Test with Bol Bol

Believe the issue is with frame container's parent not being document.body, because root scroll parent is used if not body. This was to make reddit desktop work properly, but causes this minor issue on twitter that may recur on other sites. For now, bespoke fix for twitter only, then more if the issue recurs elsewhere.

• View player
• View player with short career
• View player with no regular season stats
• View player with no post season stats
• Responsive design
• Settings persistence
• Dark mode
• Cache replacement

It would be better to have the first row career stats and have rows below be yearly stats counting backwards. I believe most use cases only care for career stats and most recent season or two.

Example: https://www.espn.co.uk/nba/story/_/id/27947336/for-culture-kd-kyrie-comes-next-nets

Increase z-index to maximum allowable or dynamically find max z-index on page and set window max + 1.

To prevent annoying accidental openings when scrolling through pages with lots of players mentioned.

Excessive usage of stats.nba.com causes throttling and possible blacklisting. Replace with own DB accessed via server.

• Get historic career stats and profiles up to 2018/19
• Set up server exposing two REST API endpoints for retrieving player list and single player info
• Update background script message handler to use new endpoints, single call per player
• Restore active player check
• Restore all star season mark
• Open server to the outside world through a domain name
• Increase time out in background script
• Server side rate limiting/authentication
• Cron job to periodically update stats and profiles for active players, back up stats
• Update readme to reflect new data source
• Remove redundant manifest permissions

Update app to recognise Steph Curry as well as Stephen Curry.

• generalise chrome browser api calls
• update empty tab check to account for empty tab names/formats in other browsers
• adjust render timing according to different browser iframe load handling

Also please let us look at and modify the allowed/disallowed sites and edit them in the options.