aabenoja / cake.parallel Goto Github PK

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

• You are currently referencing Cake.Core 0.25.0. Please upgrade to 0.28.0
• The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />
• Your addin should target netstandard2.0. Please note that there is no need to multi-target, netstandard2.0 is sufficient.
• The nuget package for your addin should use the cake-contrib icon. Specifically, your addin's .csproj should have a line like this: <PackageIconUrl>https://cdn.rawgit.com/cake-contrib/graphics/a5cf0f881c390650144b2243ae551d5b9f836196/png/cake-contrib-medium.png</PackageIconUrl>.
• There should be a YAML file describing your addin on the cake web site. Specifically, you should add a .yml file in this repo

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.

I wasn't aware of this module, as I hadn't seen it pushed to nuget.org. Are you planning on doing this?

Since cake supports "dependees" where a task can declare itself to be the dependency of other tasks, cake.parallel should support processing dependees and adding those to graph too.

The cake-contrib organization has an automated process to audit all cake addins to verify it they follow best practices, references latest cake DLLs, etc. Unfortunately this process is unable to audit your addin because it's unable to correlate the nuget package with the source project on github.

To solve this issue, can you please add projectUrl in your nuspec and republish your nuget package? This will allow nuget.org to display the Project Site on your package's download page and therefore allow the automated audit process to correlate the package and the source project.

@aabenoja now that you have pushed the NuGet Package to NuGet.org (#1), I was wondering if you would consider something else...

Have you seen this blog post:

http://cakebuild.net/blog/2016/08/cake-contribution-organization

We are currently going through a process of increasing the visibility of addins, and also trying to ensure their long term maintainability.

To that end, we are asking addin creators to add the cake-contrib user on NuGet as a co-owner (this can be done through the NuGet website by clicking on Manage Owners on the package page).

Would you be interested in doing this? If you have any questions about this, please let me know. There was some initial concern that the Cake Team were trying to "take over" packages, and that couldn't be further from the truth, and if you have this concern, or others, I would like to address them.

Thanks!

Thanks again for creating this Cake Module, we really appreciate the effort that you have put in to creating it.

We, the Cake Team, recently announced a new Cake Contrib Icon, details of which can be found here:

http://cakebuild.net/blog/2017/06/new-cake-contrib-icon

Would you consider changing the nuspec file for your NuGet Package to use this new Cake Contrib Icon? If so, the recommended URL to use is:

https://cdn.rawgit.com/cake-contrib/graphics/a5cf0f881c390650144b2243ae551d5b9f836196/png/cake-contrib-medium.png

Details of the above URL can be found in the repository here:

https://github.com/cake-contrib/graphics

Please let me know if you have any questions.

What You Are Seeing?
Cake.Parallel module does not install successfully when using the bootstrap argument.

What is Expected?
Module should install successfully.

What version of Cake are you using?
0.25.0

Are you running on a 32 or 64 bit system?
64

What environment are you running on? Windows? Linux? Mac?
Windows

Are you running on a CI Server? If so, which one?
Yes. TFBuid

How Did You Get This To Happen? (Steps to Reproduce)

In build.cake added the module Preprocessor Directives

#module "nuget:?package=Cake.Parallel.Module&prerelease=true"

Using the bootstrap parameter to install the module fails with an error

build.ps1 --bootstrap

Output Log

2018-02-21T14:13:55.1024598Z Preparing to run build script...
2018-02-21T14:13:57.6963592Z Running build script...
2018-02-21T14:14:11.0563213Z Error: Failed to install module 'Cake.Parallel.Module'.
2018-02-21T14:14:11.1813253Z ##[error]Process completed with exit code 1.