The amdh's discuss from a-yatta

amdh's Issues

Is it mean I need import Manually ?

File "amdh.py", line 1, in <module> from core.adb import ADB ImportError: No module named core.adb

Which cis is in use in this repo?

Hi,

Which cis and android version match this project?
It was not mentioned in the description

Thank you

Detect adb if it's in PATH

My adb bin is in /home/nicolas/Android/Sdk/platform-tools/adb but it's resolved by my Linux PATH.

If I run the script, it search for /usr/bin/adb by default, I need to provide it manually through -a.

It'll great to have it resolved automatically by using the PATH env var

Print ADB errors

When adb encounters an error, typically when the devices isn't authorised, the program fails with a Trackback.

It should be clearer if it prints the adb error message and stop gracefully.

The trackback in my case was :

➜ python amdh.py -sA -a /home/nicolas/Android/Sdk/platform-tools/adb
[-] INFO: List of devices:
[-] INFO: The device 97UAY124RZ will be used.

Traceback (most recent call last):
  File "amdh.py", line 408, in <module>
    amdh()
  File "amdh.py", line 209, in amdh
    packages = adb_instance.list_installed_packages(arguments.app_type)
  File "/home/nicolas/Dev/playground/python/AMDH/core/adb.py", line 48, in list_installed_packages
    output_command = self.adb_exec(adb_command)
  File "/home/nicolas/Dev/playground/python/AMDH/core/adb.py", line 25, in adb_exec
    result = run(commands_array,
  File "/usr/lib/python3.8/subprocess.py", line 512, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/home/nicolas/Android/Sdk/platform-tools/adb', '-s', '97UAY124RZ', 'shell', 'pm', 'list', 'packages', '-3']' returned non-zero exit status 1.

And the adb message was:

➜ adb shell pm list packages -3
adb: device unauthorized.
This adb server's $ADB_VENDOR_KEYS is not set
Try 'adb kill-server' if that seems wrong.
Otherwise check for a confirmation dialog on your device.

Recommend Projects