a-x- / table-builder Goto Github PK

It does not work in browser, I have added the tablebuilder.js to my assets, copied from node_modules as you describe. I get Uncaught ReferenceError: Table is not defined
Call is (new Table({ 'class': 'some-table' })) .setHeaders(headers).setData(data).render()

Thanks for this library! I was thinking of building it myself but you've gotten off to a good start.

I'd like to contribute, but just have a small request for now so I'll paste it as an issue.

In your buildFooter function, if no totals are used, there is a blank <tfoot></tfoot> added. This doesn't look great on tables with borders as it appears to be a blank row. Add this patch to the buildFooter function to return an empty string:

        if (content.length > 2) {
          return '<tfoot><tr>' + content.join('') + '</tr></tfoot>';
        } else {
          return ''
        }

This is such a beautiful library, thank you. Noticed that the class names for the td cells substitue underscores in the property name to hyphens.

In my data, the property name is mla_name but in the html I can see the td class set to mla-name-td

It would be a lot more convenient if the property name mla_name was preserved as the class names for consistency.