99x / w3c-link-validator Goto Github PK

Would be great if there is a code style to follow. (eslint config?)

At the moment there is a mix, not sure which to follow.

E.g.

if(xyz){
     console.log(xyz);
}

or

if (xyz) {
    console.log(xyz);
}

etc.

Enhancement for clarity when finding rulesets. As rule arrays get larger, it would be best to modulize or at least move them out of the validateHtml function.

Thus, making it similar to find ruleset one is looking for when reading code.

Description

there's an error at each execution of the command line

HTML SUMMARY
✖ 7 problem(s) found

Adding 33 link(s) to the queue...



▶ http://localhost:8000/prices/single-product.html

BASE	single-product.html
STATUS	404 Not Found
ELAPSED	0.01 secs

❯ Checking HTML guidelines...


HTML SUMMARY
✔ no problem found

path.js:7
    throw new TypeError('Path must be a string. Received ' + inspect(path));
    ^

TypeError: Path must be a string. Received null
    at assertPath (path.js:7:11)
    at Object.basename (path.js:1355:5)
    at runValidator (/usr/local/lib/node_modules/w3c-link-validator/src/w3clink.js:70:22)
    at Request._callback (/usr/local/lib/node_modules/w3c-link-validator/src/w3clink.js:117:13)
    at Request.self.callback (/usr/local/lib/node_modules/w3c-link-validator/node_modules/request/request.js:185:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:191:7)
    at Request.<anonymous> (/usr/local/lib/node_modules/w3c-link-validator/node_modules/request/request.js:1157:10)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)

Steps to Reproduce

1. npm install w3c-link-validator -g
2. w3clink check http://localhost:8000

Expected behavior: no error

Actual behavior: error

Reproduces how often: every single time

Versions

Package: 1.0.0

npm: both 3.10.10 & 5.6.0

node: both 6.9.3 & 9.8.0

Screenshot of the README file needs to be updated (with line number version)

Complete TODO tasks in each rule set
Reference : https://www.w3.org/TR/html5/

Update : You can add few new rules to rulesets and make a PR.

runValidator fails with an exception when a mailto: URL is found in the page. The application then terminates with:

internal/validators.js:112
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object
    at validateString (internal/validators.js:112:11)
    at Object.basename (path.js:1157:5)
    at runValidator (/home/eon/eon-com-relaunch/node_modules/w3c-link-validator/src/w3clink.js:72:22)
    at Request._callback (/home/eon/eon-com-relaunch/node_modules/w3c-link-validator/src/w3clink.js:120:13)
    at Request.self.callback (/home/eon/eon-com-relaunch/node_modules/request/request.js:185:22)
    at Request.emit (events.js:210:5)
    at Request.<anonymous> (/home/eon/eon-com-relaunch/node_modules/request/request.js:1161:10)
    at Request.emit (events.js:210:5)
    at IncomingMessage.<anonymous> (/home/eon/eon-com-relaunch/node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:299:28) {
  code: 'ERR_INVALID_ARG_TYPE'
}

I have been able to resolve this by replacing

var _base = path.basename(urlinfo.pathname);

with

var _base = path.basename(urlinfo.pathname || urlinfo.href);

but I haven't really tested it.

@thinkholic

Add CONTRIBUTING.md to move current contribute info from README.md and add place for ruleset standards.

Currently working on PR. #52 ✔️

Enhancement for user.

Add link to google/other styleguide per rule so the user can find a greater explanation of a rule. Thus, if the user doesn't understand the problem from the short explanation, they can view style guide itself that usually has example etc.

This could also be added to show when verbosity is turned up, though would take up a lot of space.

• I have tried looking for similar issues and I am sure this is a new issue.

Description

[Consise description of issue]

Steps to Reproduce

1. [Step One]
2. [Step Two]
3. [and so on...]

Expected behavior: [What you expect to happen]

Actual behavior: [What actually happens]

Reproduces how often: [What percerage of the time does it reproduce?]

Versions

Please include package version (in package.json), npm version (npm -v), node version (node -v), OS and any other relevant software versions

Package: [0.0.0]

npm: [0.0.0]

node: [0.0.0]

Additional Information

[Any other infomation, configuration or data that might be necessary to reproduce this issue.]