Git Product home page Git Product logo

aws-ecr-gc's People

Contributors

ags avatar christingruber avatar mtibben avatar pda avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

aws-ecr-gc's Issues

Getting panic errors

Whilst running the tool over our images in CI, we have started getting the following intermittent errors:

running aws-ecr-gc	0s
Total images in workbench-ci (us-east-1): 21
Images to delete (1)
  2017-05-22 05:54:32: sha256:2e1595173... []
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x6df7e4]
 
goroutine 1 [running]:
github.com/99designs/aws-ecr-gc/registry.(*Session).DeleteImages(0xc42000e0a0, 0x7ffdeac09f4a, 0xc, 0xc42025af40, 0x1, 0x1, 0x1, 0x1, 0x711740)
	/home/pda/go/src/github.com/99designs/aws-ecr-gc/registry/ecr.go:76 +0x3b4
main.main()
	/home/pda/go/src/github.com/99designs/aws-ecr-gc/main.go:64 +0x520

Fails on empty ECR repository

For a brand new ECR repository which has never had an image pushed:

panic: InvalidParameter: 1 validation error(s) found.
--
  | - minimum field size of 1, DescribeImagesInput.ImageIds.
  |  
  |  
  | goroutine 1 [running]:
  | main.main()
  | /Users/pda/go/src/github.com/99designs/aws-ecr-gc/main.go:57 +0x308

Add support to `dry-run` flag

This flag is usually a good feature to have. Specially for new adopters who want to understand a little bit more about the code and would want to understand what the code would do once it's fired without risking it's own infrastructure. :)

If you guys are keen, I would be glad to create a PR for this.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.