96-lb / kyoyobot Goto Github PK

Currently, to create a new trigger type/parameter set you need to define a new function and all its arguments in toes/triggers.py. This gets a bit unwieldy, as we need to create distinct types for very similar triggers that differ only by one small piece, such as what type of emoji they react with. Since all the trigger types are just compositions of smaller triggers, we could definitely refactor the system in such a way that we don't need to assign special names for each of these types and instead make the smaller pieces accessible from config.jason. For example, instead of a hardcoded "type": "user_reaction_standard" which gets maps to trigger_user_reaction_standard(), we could have something like "type": "user probablility reaction_standard" which gets parsed and sends all its arguments through if_author(), with_probability(), and action_react_standard(). This would prevent us from needing to define a new trigger type in the code if, for example, we decide to make a trigger which reacts and sends a response, as we could just change the type to "type": "user probability reaction_standard response" and pass it through the same logic.