8890q / android_device_samsung_universal8890-common Goto Github PK

Same issue which is present on OneUI ported ROM, due to using oreo trustlets and mobicore in conjunction with pie keymaster and fingerprint.
I have tried to revert to oreo fingerprint, keymaster but that did not worked.

OneUI discussion link ananjaser1211/FloydQ_Reports#158

This is caused by removal of fd close from libexynoscamera3.so lib
77e12d1

thing is with this edit both fd close are likely removed while we need it to stay so fds get closed properly

figure out which fd close we can keep to make fdsan not go mad or how to disable fdsan

log should be quite clear once fd close is readded

The current sepolicy is made on top of old 15.1 sepolicy plus rules added to adapt it to P and Q.
Since we did a complete rebase of both kernel and blobs, many rules can be dropped.
It could be a good idea to switch to use common Samsung SLSI sepolicy and add missing rules on top.

During a call, the called people ears an echo of its own voice. This is due to the noise cancelling mic acting.
So far I have tried to disable 2nd mic from mixer_paths but this did not worked.
The right solution would be to make lifevibes noise cancelling libraries working but currently those crashes :

09-10 10:54:09.197 3461 30995 E LvveTxBundle: LVVEFS_Android_Wrapper: Session 497: Session_SetConfig: ERROR format is wrong 5 5 1 09-10 10:54:09.198 3461 30995 E LvveTxBundle: LVVEFS_Android_Wrapper: Session 497: ProcessingFx_Command: cmdCode Case: ERROR EFFECT_CMD_CONFIGURE returned -22 from Session_SetConfig

funny enough, the exact same crash is present even when using stock audio hal on aosp.

I have forward ported a patch for debugging lifevibes, but that currently does not work as well : https://review.lineageos.org/c/LineageOS/android_frameworks_av/+/286482

Hello Devs
First off I want to thank you for mainting this device code! I'm successfully running Lineageos-18.1 on the s7 flat.
However I needed the following fix to be able to build it (I know this does not concern you I just added this for completion):

project hardware/samsung/
diff --git a/hidl/thermal/[email protected] b/hidl/thermal/[email protected]
index ddc9104..17c14a5 100644
--- a/hidl/thermal/[email protected]
+++ b/hidl/thermal/[email protected]
@@ -1,4 +1,5 @@
 service vendor.thermal-hal-2-0 /vendor/bin/hw/[email protected]
+    interface [email protected]::IThermal default
     interface [email protected]::IThermal default
     class hal
     user system

I had 2 major bugs from which I was able to solve one namely the camera.
(*) After inspecting the working build of @ivanmeler of lineageos-18.0 at xda-developers I figured that only the following libraries where different:

diff --git a/universal8890-common/proprietary/vendor/lib/hw/[email protected] b/universal8890-common/proprietary/vendor/lib/hw/[email protected]
index 12ccd5f3..e8d83d21 100644
Binary files a/universal8890-common/proprietary/vendor/lib/hw/[email protected] and b/universal8890-common/proprietary/vendor/lib/hw/[email protected] differ
diff --git a/universal8890-common/proprietary/vendor/lib64/hw/[email protected] b/universal8890-common/proprietary/vendor/lib64/hw/[email protected]
index 57893980..0831a40f 100644
Binary files a/universal8890-common/proprietary/vendor/lib64/hw/[email protected] and b/universal8890-common/proprietary/vendor/lib64/hw/[email protected] differ

So I copied them over and now the camera seems to work.
The other issue I'm unable to resolve is the graphics.composer. I get the following fatal in logcat whenever the screen tries to rotate (regardless of the app/Launcher wanting to rotate it):
graphics.composer.log

Is this a known issue?
I tried to copy over the stuff from the working build (*) again which did not work.
I also tried to revert from hwbinder to passthrough (change by @fcuzzocrea:Ic10e93398363f03551afe39715cb664bbbce1683) but without success. The fatal crash is still persistent.

For now I just switched off the autorotate function but it would be nice if this would work (again?).

Can I be of any help to resolve this?