Git Product home page Git Product logo

Comments (15)

ckoppenhaver avatar ckoppenhaver commented on July 18, 2024 1

We are just using the basic menu provided by the theme, we are nesting pages under parents. We haven't used a menu creator just whats out of the box.

from dnn-theme-bootstrap4-instant.

Tychodewaard avatar Tychodewaard commented on July 18, 2024 1

@existenze If you tweak something yourself in the code, you'll be a step further.

Step 1: Remove NodeSelector=",0,0" from <dnn:MENU MenuStyle="nav/main" NodeSelector=",0,0" runat="server" /> in default.aspx

Step 2: Add some css (below current state, still WIP)

nav#nav-desktop ul {
margin: 0;
padding: 0;
display: flex;
list-style: none;
}

nav#nav-desktop ul li {
padding: 0 15px;
height: 30px;
position: relative;
}

/* this stuff makes the submenu disappear and then appear on hover */

nav#nav-desktop li.has-child > ul {
display: none;
}

nav#nav-desktop .has-child:hover > ul {
display: block;
position: absolute;
top: 30px;
left: 0;
background-color:#fff;
padding-top: 1em;
padding-bottom: 1em;
}

from dnn-theme-bootstrap4-instant.

iJungleboy avatar iJungleboy commented on July 18, 2024

I presume you're using some kind of menu-generator to create the drop-down, possibly with DDRMenu or something. Since that basically generates HTML structures, and this theme uses bootstrap 4, you would need to check that this HTML for the menu does it the bootstrap-4 way.

I know that the menu-generation can be configured / templated, best google that a bit. I'll check internally with @lucatescari if he knows more about this.

from dnn-theme-bootstrap4-instant.

iJungleboy avatar iJungleboy commented on July 18, 2024

@ckoppenhaver So in this case the html generated there is not bootstrap 4 - you should either switch to the bootstrap 3 theme https://github.com/2sic/dnn-theme-bootstrap3-instant or customize the menu-rendering to make it BS 4 - if you do, please share :)

from dnn-theme-bootstrap4-instant.

enfJoao avatar enfJoao commented on July 18, 2024

Hey @iJungleboy
Sorry for raising the dead, but I find your theme menu beautiful, and I'm planing on using it as a base to develop my own.
However I can't quite figure if you intend to implement the sub-menu dropdown feature, or not.
I can see a "sub" folder next to main and main-mobile. What is that? A DDR-Like menu?

How long do you think it would take you to implement a dropdown main menu (at least one level) in this theme?

from dnn-theme-bootstrap4-instant.

iJungleboy avatar iJungleboy commented on July 18, 2024

@existenze there's a pull for this which we plan to integrate - but not till next week because we're under really high pressure as we want to release 2sxc 10 on towel day...

from dnn-theme-bootstrap4-instant.

enfJoao avatar enfJoao commented on July 18, 2024

@iJungleboy that pull request will not be enough since the menu code does not actually exist (at least in the version I downloaded).
There are also some other "minor" issues like the language and login skin objects that could use some theming :)
If you could find the time to do this, and release the code to the community in a new version, I would be more than willing to work with your team for at least the same amount of time in whatever work I can help you with (translating, testing, beta testing, etc).

from dnn-theme-bootstrap4-instant.

iJungleboy avatar iJungleboy commented on July 18, 2024

@existenze thx Joao. We'll try to fit it in next week or so.

from dnn-theme-bootstrap4-instant.

enfJoao avatar enfJoao commented on July 18, 2024

Also, if you could release some basic documentation on webpack it would be useful. I get errors and more errors when using it on you theme with the config files included.
Perhaps it's me being n00bish again. Even the nav sub menu submited in the pull request do not work for me.

I'll wait untill next week then.

Thanks.

from dnn-theme-bootstrap4-instant.

enfJoao avatar enfJoao commented on July 18, 2024

So... is there any chance this can be looked soon?

If we get submenus working there's 99% chance I'll use this theme.

from dnn-theme-bootstrap4-instant.

iJungleboy avatar iJungleboy commented on July 18, 2024

As of now I can only say that we won't have resources for this till summer vacation (in 2 weeks), and then nothing will happen during summer. So this won't happen for at least 8 weeks, sorry.

from dnn-theme-bootstrap4-instant.

enfJoao avatar enfJoao commented on July 18, 2024

So... you think September will be a good month to look this up?

from dnn-theme-bootstrap4-instant.

Tychodewaard avatar Tychodewaard commented on July 18, 2024

@iJungleboy How many resources do you need? I still have hours on my 'account'.
If you could squeeze it in, it would be great. If the planning is further away, I'll pick it up myself. So, please elaborate on the planning before actually start the work.

from dnn-theme-bootstrap4-instant.

WillStrohl avatar WillStrohl commented on July 18, 2024

Is this at all related to disabled pages not displaying or functioning properly in the menu? Similar issue... Though I haven't yet debugged it, this appears to be that disabled (anchor) pages just aren't yet implemented in the menu provider in this theme. Right?

from dnn-theme-bootstrap4-instant.

iJungleboy avatar iJungleboy commented on July 18, 2024

I seriously don't know. I'm not even sure what you mean by an "Anchor" page?

But either way I'm sure it's simple to add, and a pull would be appreciated ;)

from dnn-theme-bootstrap4-instant.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.