2ndquadrant-it / puppet-barman Goto Github PK

Howdy! If you are able can you release a new version of your module with the recent updates to the Puppet Forge? Thanks!

Any chance for a new release on the puppet forge?

parallel_jobs is currently not supported as parameter.

Hello,
in class barman::settings there is a duplicate declaration, which makes puppet parser validate fail:

class barman::settings (
...
  $pre_backup_script       = false,
  $post_backup_script      = false,
...
  $basebackup_retry_sleep  = false,
  $pre_backup_script       = false,   <==== !!
  $post_backup_script      = false    <==== !!

Hello,
for your information,

<%- if @backup_directory -%>
backup_directory = <%= @backup_directory %>
<%- end -%>

is written twice in server.conf.erb (lines 17,18 19 and lines 128 129 130)

I'm not sure i needed to do a pull request for that....

thanks

See subject

Currently the custom_lines parameter is marked as deprecated, but there's no alternative for configuring - for instance - streaming_archiver.
Would you accept a PR extending barman::server to support all current relevant settings?

This is just a reminder issue to convert barman to use puppet4 types and get rid of a lot of type validation! 😉

Hi,

Thanks for your great job on this module.
I have an issue with the home parameter.

I use the module with :

  class { 'barman':
    autoconfigure       => true,
    home                => '/opt/barman',
    exported_ipaddress  => "${::networking['ip']}/32",
    manage_package_repo => false,
  }

And the archive_command is always with /var/lib/barman

Thanks.
Mélanie.

I believe a1afc14 introduced a regression: before this commit, a single postgresql::server::pg_hba_rule was realized in barman::autoconfigure. Now two of them get realized inside barman::server, which itself can be instantiated multiple times. Since the pg_hba_rules get instantiated with the same titles (based on $::hostname), we hit a "duplicate declaration" error as soon as we have more than one declared for the same host.

I need to use puppetlabs-postgresql version 5.0.0 (or newer), but your module requires <5.0.0

Could you bump the dependencies for your module?

I've configured a backup server and now on a DB server I'm hitting following error:

A duplicate resource was found while collecting exported resources, with the type and title Ssh_authorized_key[barman]

backup server:

  class { 'postgresql::globals':
    manage_package_repo => true,
  }->
  class { 'barman': }

  @@host { $::fqdn:
    ensure       => 'present',
    name         => $::fqdn,
    host_aliases => $::hostname,
    ip           => pick($::ipaddress_eth0, $::ipaddress),
  }
  Host <<| |>>

DB server:

include barman::postgres

Am I missing something?

It would be nice to be able to configure $retention_policy from barman::postgres and then have that class pass it to barman::server. This looks like it would be a easy addition since barman::server already accepts the $retention_policy parameter. I don't mind submitting a pull request if that is ok.

when setting postgresql_server_id through barman::postgres it's not used consistently, the exported resource will still be named $::hostname, and so barman will be expecting its wal to show up in /var/lib/barman/$hostname/incoming/ rather than in /var/lib/barman/$postgresql_server_id/incoming/

I am already defining postgresql::globals to configure my servers. barman shouldnt interfere with this

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate declaration: Class[Postgresql::Globals] is already declared

Hi,

I wonder why $name in server.pp is limited to lowercase characters (etc.).
I'm using Barman (w/o the Puppet module) with all-uppercase names since years, no issues whatsoever.
Moving to the Puppet module will force me to do a lot of renaming... :/

Nick

P.S.: the comment reads
"# check if 'description' has been correctly configured"
which is (pretty obviously) wrong.
P.P.S.: Same goes for the "validate_re($ensure," line.

Could you please tag on github the released version on the forge ?

On a Solaris 11 host configured by puppet, pluginsync will pull down the barman_key.rb fact and when it tries to process the postgres_key fact I get:

root@solaris11:~# facter -p postgres_key
Could not create directory '//.ssh'.
open //.ssh/id_rsa failed: No such file or directory.
root@solaris11:~#

This is due to Solaris's entry in passwd for postgres looking like this:

postgres:x:90:90:PostgreSQL Reserved UID:/:/usr/bin/pfksh

Since this module is only supported on Linux, perhaps a quick fix for this is to confine the facts to :kernel => 'Linux' ?

Barman package gets updated whenever yum update or yum cron update is run.

In some circumstances it is beneficial to have an opportunity to lock the package to some version, say, the newest version has a bug or there are some breaking changes that need investigation.