201-created / ember-cli-airbrake Goto Github PK

hi Guys,
We were using v0.0.7 in our project and stopped using it last year. I reenabled it by adding the airbrake object
ENV.airbrake = {
projectId: 'real_project_id',
projectKey: 'real_key'
};
However, I dont see any data being sent to airbrake - I confirmed by looking at the n/w traffic.
Issue seems to be that in following function in file airbrake.js
export function initialize(container) {
if (config.airbrake && !isSetup) {
isSetup = true;
if (Airbrake.setProject) {
setupAirbrake(container);
} else {
Airbrake.onload = function() {
setupAirbrake(container)
};
}
}
}

the onload event is never fired so setupAirbrake(container) is never called. Any ideas?

The ember-cli-babel dependency should be updated to the latest version to allow consuming apps to drop ember-cli-shims as a dependency of ember 2.16+ apps.
https://www.emberjs.com/blog/2017/11/20/ember-2-17-released.html#toc_changes-in-ember-cli-2-17

How to enable sourcemap on this if it is available? Would want sourcemap to be generated, deployed but do not have //# sourceMappingURL=xxx.map in the javascript source code.
https://github.com/airbrake/airbrake-js#filtering-errors

vendor/airbrake-shim.js is imported even if ember-cli-airbrake isn't configured. I have had a quick look into doing this but it seems that we cannot get access to the users environment configuration from index.js. One option would be moving it into the config which is passed to EmberApp in the brocfile as this is accessible on the app variable but this would change the API of the addon. ember-cli-defeatureify and ember-cli-browserystats use this approach.

See #8

In newer ember the Ember.onerror handler gets called for route transition errors, but in older Ember one must add an error action handler directly. Document this.

Hi :)
Do you intend to continue maintenance of this package?
We should upgrade airbrake client and we can also move it to from bower to npm.

Hello,

Ha version including PR #29 has not yet been released to npm, could you please provide?

Thanks!

The last npm release was cut over a year ago, and it's missing several recent commits.

Ember provides a customised default for RSVP.onerror. We override this and so it removes a lot of the behaviour they have added. No idea if we need all of this but one problem which manifested itself is the catching of TransitionAborted errors which the ember version filters out.

https://github.com/emberjs/ember.js/blob/85550ca7f91883838953e736caa6ef51daabf255/packages/ember-runtime/lib/ext/rsvp.js#L53

Theoretically we don't actually need to override this as it defaults to Ember.onerror if defined and we define it.

I'm using this addon with Errbit and had to add rack-cors to get it working (it looks like it uses an old version of the Airbrake API? Version 0.3 instead of 0.5). Anyway, from there I can push errors using Airbrake.push('error'). No browser or Ember errors get pushed though. Raising an error using throw 'test' doesn't get pushed. Neither do Ember errors. The following being an example:

model: function() {
    return this.get('sessionUser.objectnothere').then(user => user.get('company'));
  },

which raises:

Error while processing route: ats.opportunities.show.all.index Cannot read property 'then' of undefined TypeError: Cannot read property 'then' of undefined
    at model...

This surely has to work with Ember 0.13.x. Am I doing something wrong?