200puls / darksky-forecast-api Goto Github PK

Please enable to set the timeout for the request.

Please add a getter for the UV Index in the Currently forecast

for example a longitude supplied as a double of -0.000066 appears in the get URL as -6.6E-5 resulting in HTTP response code: 400

Hi
i am using dark sky forecaste api in java
i am getting this error
com.fasterxml.jackson.datatype.jsr310.deser.JSR310DateTimeDeserializerBase.findFormatOverrides(Lcom/fasterxml/jackson/databind/DeserializationContext;Lcom/fasterxml/jackson/databind/BeanProperty;Ljava/lang/Class;)Lcom/fasterxml/jackson/annotation/JsonFormat$Value;

There is a problem with the formatting of decimal numbers. In countries where the notation differs from something like 5.75 the url is not formatted correctly.

Example code from read.me at "https://github.com/200Puls/darksky-forecast-api":

ForecastRequest request = new ForecastRequestBuilder()
.key(new APIKey("key"))
.location(new GeoCoordinates(new Longitude(13.377704), new Latitude(52.516275))).build();

    DarkSkyJacksonClient client = new DarkSkyJacksonClient();
    //Forecast forecast = client.forecast(request);

    /* I added this to see what's happening -> */ System.out.println(request);

/System.out.println("forecast " + forecast);
System.out.println("forecast " + forecast.getCurrently().getTemperature());/

You get the following by the "System.out.println(request);" statement:
ForecastRequest{url=https://api.darksky.net/forecast/key/52,516275,13,377704?lang=de&units=si}

But it should be something like this:
ForecastRequest{url=https://api.darksky.net/forecast/key/52.516275,13.377704?lang=de&units=si}

If you stick with commas you will get an http-response-code 400 "bad request". At least you are in a country like germany.

I tried to request data with "https://api.darksky.net/forecast/key/52.516275,13.377704?lang=de&units=si" and it worked pretty well.

Apart from this bug, you made an awesome job. This is a great library.

Cannot construct instance of tk.plogitech.darksky.forecast.model.Longitude (although at least one Creator exists): no int/Int-argument constructor/factory method to deserialize from Number value (50)

Apple has purchased Dark Sky and is shutting down the API.
The API will continue to function through the end of 2021.
More Informations