Describe the bug

We found a bug while using this plugin where deleting an item from a search does not revert the "added" label correctly. You can see the bug in action in this loom video

Steps to Reproduce

1. Go to a post
2. Search for a related post
3. Add 2nd post from the result. The "add" button in this search result should change to the "added" label.
4. Remove the post you just added by clicking on the "delete" button.
5. You will see that the "added" label does not change to the "add" button,

Screenshots, screen recording, code snippet

https://www.loom.com/share/d7de2a0e38204d4baf83f32173c3a57e

Environment information

No response

WordPress information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

NOTICE: wp-content/plugins/wp-content-connect/includes/QueryIntegration/WPQueryIntegration.php:58 - Undefined index: orderby
include('wp-admin/edit-form-advanced.php'), do_action('add_meta_boxes'), WP_Hook->do_action, WP_Hook->apply_filters, TenUp\ContentConnect\UI\MetaBox->add_meta_boxes, apply_filters('tenup_content_connect_post_relationship_data'), WP_Hook->apply_filters, TenUp\ContentConnect\UI\PostToPost->filter_data, WP_Query->__construct, WP_Query->query, WP_Query->get_posts, apply_filters_ref_array, WP_Hook->apply_filters, TenUp\ContentConnect\QueryIntegration\WPQueryIntegration->posts_orderby

Is your enhancement related to a problem? Please describe.

First of all, thanks for sharing this.

The 'relationship_query' argument on queries currently only work for WP_Query and not for get_posts().

Is there an underlying reason for this?

While we can easily use WP_Query on our own developments, I'm now in a situation where I need to hook into other plugin queries, and manipulate them to return only related posts, and it doesn't work because at the end they+re using get_posts() an not WP_Query.

For example, I'm trying to manipulate the options on a WPForms field, by using their wpforms_dynamic_choice_post_type_args filter without success because they're using get_posts().

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug

If WooCommerce is active and using the new High Performance order Tables, this plugin throws several notices on the order edit screen (wp-admin/admin.php?page=wc-orders&action=edit&id=12345)

Notice: Function post_type was called incorrectly. Order properties should not be accessed directly. Backtrace: do_action('load-woocommerce_page_wc-orders'), WP_Hook->do_action, WP_Hook->apply_filters, Automattic\WooCommerce\Internal\Admin\Orders\PageController->__call, call_user_func_array, Automattic\WooCommerce\Internal\Admin\Orders\PageController->handle_load_page_action, Automattic\WooCommerce\Internal\Admin\Orders\PageController->setup_action_edit_order, Automattic\WooCommerce\Internal\Admin\Orders\PageController->prepare_order_edit_form, Automattic\WooCommerce\Internal\Admin\Orders\Edit->setup, do_action('add_meta_boxes'), WP_Hook->do_action, WP_Hook->apply_filters, TenUp\ContentConnect\UI\MetaBox->add_meta_boxes, apply_filters('tenup_content_connect_post_relationship_data'), WP_Hook->apply_filters, TenUp\ContentConnect\UI\PostToPost->filter_data, WC_Abstract_Legacy_Order->__get, wc_doing_it_wrong Please see Debugging in WordPress for more information. (This message was added in version 3.0.) in /Users/marcoalmeida/Documents/Websites/_local/wordpress-testing/app/public/wp-includes/functions.php on line 6078

Steps to Reproduce

1. Activate this plugin
2. Activate WooCommerce
3. Activate HPOS on WooCommerce
4. Got to a order edit screen and see the notices

Screenshots, screen recording, code snippet

Environment information

No response

WordPress information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is your enhancement related to a problem? Please describe.

It would be a UX improvement to have the option to create a new related post from within the post meta box of another post. The use case is if you need to relate a post to another post that does not yet exist. We could create a button, that when clicked, hits a custom endpoint that will create a new post (of the appropriate CPT based on the relationship settings) and automatically create the relationship. The endpoint will then return the ID of the new post, and open the editor for that new post in a new tab. It will also need to update the "Related Posts" listing in the post where it was originally created.

Designs

The design for the button would be similar to the "+ Add New Category" button for taxonomies, except it would open the cpt in a new window since a CPT would have a lot more details to fill in.

Describe alternatives you've considered

We could just add a filter at the bottom of the render function ( https://github.com/10up/wp-content-connect/blob/master/includes/UI/MetaBox.php#L40 ) and allow developers to add whatever they would like under the meta box, but it would be difficult to trigger a refresh of the related post list.

Code of Conduct

• I agree to follow this project's Code of Conduct

Search for define_post_to_post won't find partial words (cambri), only complete ones (cambridge).

Is your enhancement related to a problem? Please describe.

In WordPress 5.0+, the Vue-based metabox created by the library doesn't look great:

Even when forced into the sidebar, it sticks out visually because it doesn't use core blocks:

Describe the solution you'd like

New JS for Gutenberg using React and core packages, creating either a metabox or a plugin sidebar.

Additional context

Using this library in a client project that needs post-to-post relationships.

Is it possible to limit the number of posts related on one side of the relationship? If the limit is set to one this would be a one-to-many relationship.

For example, if I have a content type, let's call it parent, connected to another, let's call it child and a definition like the following:

$args = array(
  'from' => array(
    'enable_ui' => true,
    'sortable' => false,
    'labels' => array(
      'name' => 'Parents',
    ),
  ),
  'to' => array(
    'enable_ui' => true,
    'sortable' => false,
    'labels' => array(
      'name' => 'Children',
    ),
  ),
);
$relationship = $registry->define_post_to_post( 'parent', 'child', 'parent-child', $args );

How do I make sure that when I edit a parent post I can add many children but if edit a child I only can add it to one parent?

An integration for WP-CLI for the core methods (add, delete, sort) on all of the relationship types (PostToPost, PostToUser)

On a client project, we want to add the content connect UI to a custom WooCommerce product tab. Changing render() and other methods within the MetaBox class to be static methods would allow other code to easily render the UI in different parts of the WP admin instead of just the built-in meta boxes.

Need to go through the queries that will be run on the custom tables and ensure that indexes are in place

The links with the names of the relationships on the edit post form are missing the cursor on hover.

This can be fixed by adding a cursor: pointer property to the .vtab-menu > a rule in wp-content-connect/assets/js/src/App.vue.

Right now, we just show the first 10 results in a search, with a nice @todo comment in the code

Search for define_post_to_user won't search for first and last name.

For example, if a user name is joesmith and the first and last name are John and Smith. I can only find him if I type the exact user name. If I search for John or Smith there won't be any results.

Also, partial words won't work for these or the user name either. See #16 for a similar issue for posts.

We have a use case where we:

• We're editing a child post
• We need to add a relationship limited to only other child posts for the current post's parent post

The proposal would be:

• Send the current post ID/user ID and the relationship name in the REST request to provider better context to the REST endpoint
• Add filters to the search_users() and search_posts() functions that pass the query args as well as the ID and relationship name to allow the query args to be adjusted as-needed

I can work on a PR for this if it seems reasonable.

When trying to pull this into a project, the plugin is always installed in a 10up directory inside the plugins folder. Which doesn't work with the installer-path setup for other wordpress-plugins.

"installer-paths": {
      "plugins/{$name}/": ["type:wordpress-plugin" ]
}

After creating this connection:

$args = array(
		'from' => array(
			'enable_ui' => true,
			'sortable' => true,
			'labels' => array(
				'name' => 'Related Hotels',
			),
		),
		'to' => array(
			'enable_ui' => true,
			'sortable' => true,
			'labels' => array(
				'name' => 'Related Stories',
			),
		),
	);
	$relationship = $registry->define_post_to_post( 'post', 'hotel', 'hotel-post', $args );

When I go to the Hotel's page, its appears that all posts has already been assigned to the hotel. wp_post_to_postis empty, and if I hit "Update", it then saves the connection.

It appears to me that in generate_join_clause(), the left join is being dropped resulting in a query for all posts. The root cause appears to be that the post_type in posts_where() is an array which breaks get_relationship_key().

Not that in my example Hotel pages display all posts, but Post pages do not display all Hotels.

There are some inconsistencies in the documentation for PostToUser methods. For instance, in PostToUser->delete_relationship, the comment in the example says:

// $relationship is the return value from ->define_post_to_post()

and it should say:

// $relationship is the return value from ->define_post_to_user()

I've seen this in at least three methods.

I think I've found an issue with the query in search_posts (https://github.com/10up/wp-content-connect/blob/master/includes/API/Search.php#L104).

If I create a post to post relationship from my-post-type to a msr-guest-profile, defined as shown below (note that public is set to false), and then I go to edit a my-post-type post and try searching a post of type msr-guest-profile nothing is returned.

I already tried changing public to true and even added exclude_from_search false in the definition of msr-guest-profile but wp-content-connect's search still doesn't return any result.

If I run the same WP_Query from any other part of the website I do see posts of type msr-guest-profile returned.

Furthermore, I can still use the add_relationship method of my-post-type to msr-guest-profile relationship and it works just fine.

function register() {

	$labels = array(
		'name'               => esc_html__( 'Guest profiles', 'example' ),
		'singular_name'      => esc_html__( 'Guest Profile', 'example' ),
		'add_new'            => esc_html__( 'Add New Guest Profile', 'example' ),
		'add_new_item'       => esc_html__( 'Add New Guest Profile', 'example' ),
		'new_item'           => esc_html__( 'New Guest Profile', 'example' ),
		'edit_item'          => esc_html__( 'Edit Guest Profile', 'example' ),
		'view_item'          => esc_html__( 'View Guest Profile', 'example' ),
		'all_items'          => esc_html__( 'Guest Profile', 'example' ),
		'search_items'       => esc_html__( 'Search Guest Profiles', 'example' ),
		'not_found'          => esc_html__( 'No Guest Profiles found', 'example' ),
		'not_found_in_trash' => esc_html__( 'No Guest Profiles found in Trash', 'example' ),
	);

	$args = array(
		'public'             => false,
		'publicly_queryable' => true,
		'show_in_rest'       => true,
		'show_ui'            => true,
		'show_in_nav_menus'  => false,
		'show_in_menu'       => 'users.php',
		'query_var'          => true,
		'label'              => esc_html__( 'Guest profiles', 'example' ),
		'labels'             => $labels,
		'has_archive'        => false,
		'supports'           => array( 'thumbnail' ),
		'rewrite'            => false,
		'capability_type'    => array( 'msr-guest-profile', 'msr-guest-profiles' ),
		'map_meta_cap'       => true,
	);

	if( ! current_user_can( 'edit_pages' ) ){
		unset( $args['show_in_menu'] );
	}

	register_post_type( 'msr-guest-profile', $args );
}

This setup gives me a PHP warning, not sure what's going on there.

add_action( 'tenup-content-connect-init', 'prefix_content_connections' );

function prefix_content_connections( $registry ) {

	$args = [
		'from' => [
			'enable_ui' => true,
			'sortable'  => true,
			'labels'    => [
				'name' => 'Related Foos',
			],
		],
		'to' => [
			'enable_ui' => true,
			'sortable'  => true,
			'labels'    => [
				'name' => 'Related Bars',
			],
		],
	];

	$relationship = $registry->define_post_to_post(
		'bar',
		'foo',
		'bar-foo',
		$args
	);
}

Is your enhancement related to a problem? Please describe.
Now that WordPress 5.3 is released, we'll want to test WP Content Connect to see if any incompatibility issues arise.

Describe the solution you'd like

• test WP Content Connect on WP 5.3
• open issues for any incompatibilities noted in testing
• resolve issues identified in testing
• bump "tested up to" version
• if code changes needed due to incompatibilities, ship a plugin release

Designs
n/a

Describe alternatives you've considered
none

Additional context
none

It's not obvious the level of support provided for this repo, so let's add some clarification.

• add support level section and badge
• add release version badge
• add license badge

It would be awesome to have support for relationship meta.

There’s often situations where data isn’t a property of one entity or the other, but exists only in the context of their relationship with each other, and it doesn’t make sense to store said data in the meta of one or the other object, but ideally somewhere between, such as relationship meta.

For example, let’s say we were making an activity stream, and we wanted “activity items” to show as “unread” or “read” (similar to email). Since activity items and users would be a many-to-many relationship, we wouldn’t want an activity to be marked “read” when any user read it, we’d only want it to be marked “read” for you, if you read it.

Currently, the options are to store an array of user IDs in the activity item meta, and use that to determine if the current user has or has not “read” the item, or you could store an array of items in each users meta. . . Neither are good solutions. Storing user IDs on the activity is likely the better of the two, but still doesn’t scale
If you have a lot of users.

It would be awesome to have a formal way to store this contextual data, and in some cases even query by it.

I believe Posts 2 Posts has support for relationship meta. Might be worth looking at for inspiration 🤷‍♂️🤔

Anyway, I can think of heaps of examples where this would be useful.

—

Gotta throw out mention of GraphQL while I’m at it... 😀

In the WPGraphQL Schema, there’s a concept of “edges” which is the space between two nodes. For example, there’s an edge between a user and a post, or a Post and a Featured Image. This “edge” space is used for exposing contextual information that’s only relevant in the context of the relationship between the two connected nodes.

WPGraphQL could easily take advantage of relationship meta by exposing it on the edges.

Is your enhancement related to a problem? Please describe.
Once WordPress 5.9 is released, we'll want to test WP Content Connect to see if any incompatibility issues arise.

Describe the solution you'd like

• test WP Content Connect on WordPress 5.9
• open issues for any incompatibilities noted in testing
• resolve issues identified in testing
• bump "tested up to" version
• if code changes needed due to incompatibilities, ship a plugin release

Designs
n/a

Describe alternatives you've considered
none

Additional context
none

Current, the UI components don't have tests. PHP tests could be added for basics like ensuring metabox is registered when there are relationships to render, etc.

• How to get relationship objects without saving return value from define

instead of adding order one by one