Git Product home page Git Product logo

0x-tracker-worker's People

Contributors

andreselizondo avatar cbovis avatar ikramansari77 avatar ktl-xv avatar opaolini avatar renovate[bot] avatar sudo-owen avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

0x-tracker-worker's Issues

Dependency deprecation warning: bugsnag (npm)

On registry https://registry.npmjs.org, the "latest" version (v2.4.3) of dependency bugsnag has the following deprecation notice:

All projects should upgrade to our universal JS notifier: "@bugsnag/js". See https://github.com/bugsnag/bugsnag-js/blob/master/UPGRADING.md for more details.

Marking the latest version of an npm package as deprecated results in the entire package being considered deprecated, so contact the package author you think this is a mistake.

Affected package file(s): package.json

If you don't care about this, you can close this issue and not be warned about bugsnag's deprecation again. If you would like to completely disable all future deprecation warnings then add the following to your config:

"suppressNotifications": ["deprecationWarningIssues"]

Handle v2.1 exchange contract events properly

Description

Changes will be made to the event extractor to ensure v2.1 events are tagged as 2.1 rather than 2. The worker will need to be updated first to ensure it can continue processing 2.1 events. The only difference in processing will be that fills are tagged with a protocolVersion of 2.1 rather than 2.

Update create fills job to handle v3 events

Description

Update the create fills job to handle new fields introduced by the v3 exchange contract. Fills should be created with a protocolFee field. The maker and taker fee asset data should be parsed and the resulting assets stored in a fees field.

Update convert fees job to support v3 fills

Description

The v3 exchange contract will allow for multiple maker/taker fees to be charged in any type of token. A new fees property will be used on fills to support this, and it will closely follow the assets shape. The existing convert fees job will need to be updated to support this fees field.

The job should pull prices for all fees which are denominated in a base token (see src/constants.js). It should convert the token amount to USD and store that against the fill.

Notes

It may actually make sense to introduce a new job rather than updating the existing job to handle two different data structures.

Store fill value when indexing fills

The index fill (src/consumers/index-fill.js) and bulk index fills (src/consumers/bulk-index-fills.js) consumers should be updated to store fill value in Elasticsearch.

Dependency deprecation warning: bugsnag (nvm)

On registry https://registry.npmjs.org, the "latest" version (v2.4.3) of dependency bugsnag has the following deprecation notice:

All projects should upgrade to our universal JS notifier: "@bugsnag/js". See https://github.com/bugsnag/bugsnag-js/blob/master/UPGRADING.md for more details.

Marking the latest version of an npm package as deprecated results in the entire package being considered deprecated, so contact the package author you think this is a mistake.

Please take the actions necessary to rename or substitute this deprecated package and commit to your base branch. If you wish to ignore this deprecation warning and continue using bugsnag as-is, please add it to your ignoreDeps array in Renovate config before closing this issue, otherwise another issue will be recreated the next time Renovate runs.

Affected package file(s): package.json

Update convert fees job to ignore v3 fills

Description

Adding full support for v3 fees will likely take a substantial amount of effort. As an interim measure the convert fees job should be updated to ignore v3 fills. This will help to ensure a quick transition to v3 support and will provide some legroom in building out full support.

Migrate to new Trust wallet repository

Description

Trust wallet has migrated their assets to a new repository (https://github.com/trustwallet/assets). The old repository still exists which means 0x Tracker hasn't been negatively impacted but it does mean that we don't receive any new token images.

The job for fetching token images should be updated to use this new repository instead of the old one.

Missing swaps on 0xTracker

Hi,

I recently seen several swap transaction that are not showing on 0xTracker for MetricExchange app. But I believe it is happening for all other apps as well

here are some I identified:

After some more debugging it seems the fills are not created due to missing Bridge events. In fact when the worker processes tries to create the TransformedERC20 fill it abort with following message:

TransformedERC20 event has no associated ERC20BridgeTransfer or BridgeFill events

Another thing I noticed is that the TransformedERC20 event is categorised of version 3 whereas the swap are all done using v4. So It might be an issue with event-extractor as well.

Also the issue seems to have started only less than 24h ago, before I never saw missing fills

Many thanks

Extract token metadata from contracts

Token names, symbols and decimals are currently fetched from Ethplorer. This integration is potentially redundant because many tokens embed metadata within their contracts.

A few tasks to be completed:

  1. Perform an analysis of traded tokens and see what percentage of their contracts contain metadata
  2. Update the existing task to fetch token details from contracts
  3. Depending on the results of point 1, remove integration with Ethplorer

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (github>0xTracker/renovate-config-0x-tracker)

Introduce job for converting V3 protocol fees

Description

V3 of the exchange contract will introduce a new protocolFeePaid field which denominates the amount of ETH paid as a protocol fee. In order to localize the fee amount on 0x Tracker it's necessary to introduce a job which fetches the ETH price on the fill date.

The job should work on fills which have not yet had their protocol fee converted. The job should fetch the ETH price, calculate the USD value of the fee, and then store both values against the fill. The existing conversions and rates fields can be used for this purpose.

Ensure V3 events are ignored when creating fills

Description

The event extractor is currently blocked from supporting V3 because any V3 events created by the extractor will be processed by the worker. To resolve this, ensure that the worker ignores events which don't have one of the following protocol versions:

  • 1
  • 2
  • 2.1

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.