In the setName function when NFT are minted, the cost of minted is 0.3 (native token), but this is by passed for some reason and throw errors when msg.value is placed, this was again due to no test for all the contracts.

Decision : There is not amount for the contract to receive, so users mint NFT only paying gas

Conclusion : Another feature 😝

For more bugs in the contracts, pls create an issue, we will be pushing a fix for all tiny bugs, there maybe bugs in the other contracts but dont forget they are still features 😝

Although this should not cause for high alarm, the contracts are 100% useable and nicely written for tests (plays, hackathons ), it may need to be audited and more optimised for production.

Use at your own risk ⛔️ lol

Warning
Disclaimer

• This contracts where made for a hackathon, they where never crossed checked, audited or professional looked at and written (even by the writer), all feature still works as intended, the contracts are on mumbai, dont lose mainnet funds.

Stay safe 💙

it turns out that the faucet wait time is not properly validated due to code not tested (rushing and forgetfulness), so users and bots can potentially mint unlimted amount of tokens as there is not wait time or cap to total supply.

but there is not specifed amount, the minted tokens are 1000 FRACT per mint function call

Decision: This is not a high threat as it is currently on the mumbai testnet and we also want users to test it and play around with it and who doesn’t like a wonky total supply ?

Conclusion : It is a feature 😝

project is not currently using the updated superfluid contract syntax, to my surprise it works and there are no error till you try the new ACL management or you import the updated contracts

Decisions : These Contracts works perfectly cause we are not importing the upgraded one or trying the new ACL features for this, Contracts will be upgraded in the future

Conclusion : I had no idea it was old lol, i saw it in the superfluid docs 🤷