Feat: IncludeInner extension method to force Parent/Children inner joins about entityframework-extensions HOT 5 OPEN

Hello @tsanton ,

Thank you for reporting.

With your text, I can definitely see the advantage of being able from time to time using the INNER JOIN instead of OUTER JOIN clause.

I will discuss it with my team this week to see if that's something we might want to implement next month or not.

Best Regards,

Jon

from entityframework-extensions.

Hello @tsanton ,

We started to take some time to think about this proposed feature.

Is replacing ALL LEFT JOIN with INNER JOIN could be a possible solution, or do you need to be able to replace depending on what you want to include, so having a method such as IncludeWithInnerJoin?

We believe the replacement of all join could be very easily done on our side, while the IncldueWithInnerJoin will take us way more research and time to make it happen (Doing the first one doesn't exclude we might eventually try to do the others).

Let me know,

Best Regards,

Jon

from entityframework-extensions.

Oh @JonathanMagnan , why do you never ask easy questions?

For now ReplaceAll would solve my issues because I create data models that will always have a group by InnerJoin compatibility (i.e. dummy row if nothing else). With time (and for everybody else inheriting old data models) individual overrides is definitely the way to go.

Before I answer (and sorry to try to pin you down) can you give estimates? I.e. if it's 2 weeks for the first (with minimal coding) and you can create a very concise api (i.e. as a final method OverrideAllJoinToBecomeInnerJoins()) then sure: a no brainer (but please deprecate it with time as it's ugly). If it's 0-4 months for the ideal solution and you're willing to prioritise it I'll become a missionary running around the frozen wastelands of Norway and the rest of Scandinavia* (*Finland and Iceland not included) preaching the holiness of ZZZ EntityFramework-Extensions if that's what it takes :)

Looking forward to hearing from you!

/T

from entityframework-extensions.

My developer will start to check the first part this week

It will be easier to give you a good estimate next Monday.

Best Regards,

Jon

from entityframework-extensions.