Comments (3)
That the depth is a float is intentional. The depth simply returns the largest 'row' value in the graph, and this can be fractional, as it works as kind of the 'x' value when drawing.
Rows and columns being switched is now fixed.
from pyzx.
Thanks for fixing this John.
I saw from the code that the depth is just the row number. I am saying that this behaviour is not desirable. (Also rows and columns should probably be integers too!)
from pyzx.
The code actually uses the fact that you can have fractional row numbers in a few places to "insert" new nodes in specific positions without having to reposition every other node. Also quantomatic of course allows floating point values for the coordinates. If we forced row and column numbers to be integers than we would have to either (1) round every coordinate when importing or (2) introduce a new coordinate system specifically for qgraph files.
I agree that it is not very intuitive that these values can be floating points, but for now it is quite useful.
from pyzx.
Related Issues (20)
- `extract_circuit` does not turn grounds into measurements and classically-conditioned gates HOT 3
- pyzx unable to optimize when circuit contains rx or sx gate HOT 3
- support custom gates with phases HOT 1
- rename `master` branch to `main`
- `pyzx.draw()` does not work in some matplotlib environments HOT 2
- Qiskit 1.0 OpenQASM 3 output breaks `qasmparser` because of spaces between phases
- `U3Gate` is deprecated in Qiskit 1.0, replaced with `UGate`, pyzx needs to handle the new gate
- `pyzx.draw()` is incompatible with dark background HOT 2
- Clifford simp adds a phase of n*pi/2 HOT 2
- Coding style HOT 4
- Boundary pivot is never matched
- Lack of documentation on the preconditions to apply existing transformations
- Clarification on applying individual transformations HOT 5
- Saving/loading is broken for multigraphs
- Methods to convert a graph to tensor/matrix do not work for multigraphs HOT 6
- Add hopf rule and self-loop removal rules for multigraph HOT 2
- Support edge_data dictionary in the graph data structure HOT 3
- Why are there three implementations of every rule: in rules.py, basicrules.py and editor_actions.py? HOT 3
- add_edge with auto_simplify is incorrect in Multigraph
- Make ZX diagram editor compatible with newer version of ipywidgets HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyzx.