Git Product home page Git Product logo

Comments (5)

zutrinken avatar zutrinken commented on August 16, 2024 2

@deadlysyn I have it on the radar. I'm currently rewriting the whole theme to support some more features like darkmode. The update branch also includes better scaling on larger screens. It's still work in progress, but feel free to check it out: https://github.com/zutrinken/attila/tree/update

from attila.

mceachen avatar mceachen commented on August 16, 2024 1

Change the .inner's max-width: mceachen@fba97dc#diff-da725cf4823250b3f76285b47c77ac46L620

from attila.

cdorin93 avatar cdorin93 commented on August 16, 2024

Good idea, thanks @mceachen for the push!

from attila.

deadlysyn avatar deadlysyn commented on August 16, 2024

First, I want to say thanks for the awesome theme...it looks amazing, and is well thought out.

Second, thanks to @mceachen for the push to DIY and easily adjust this (highly personal) preference. :-)

I've been reading Heydon Pickering's Inclusive Design Patterns. A section on paragraph structure references Robert Bringhurst’s book The Elements of Typographic Style which recommends a measure between 45 and 75 characters (based on a lot of psychology and studies about optimal line lengths for readability and accessibility).

Refer to Pickering et al pg. 51-52 if you want more detail, but in CSS this would boil down to a comfortable range somewhere around:

figure figcaption {
    max-width: 60rem;
}

.inner {
    max-width: 60rem;
}

I'm not a designer, I don't even play one on YouTube, but if this is thought to be a reasonable default I'm happy to submit a PR. I notice on my personal blog it is not much different than the default. The original text's idea is for font size to be fully relative, vs snapping across break points... so truly "fixing" this requires a bit more surgery. Not sure if that deserves a PR or fork, since it may become a divergence of opinion. :-)

from attila.

cdorin93 avatar cdorin93 commented on August 16, 2024

Awesome, thank you very much for your work! Looking forward to seeing the update :)

from attila.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.