Get rid of duplicate code about zulipbot HOT 8 CLOSED

Authentication would definitely be great. We're looking for responses a lot of the time we use a label function, but we can probably have the function return the associated labels if necessary.

from zulipbot.

@zulipbot label "feedback wanted", @zulipbot claim

from zulipbot.

Not sure if we can actually write functions for removing/adding labels, since we need to access the responses...

from zulipbot.

Sure, it'll probably work out.

from zulipbot.

@synicalsyntax working on authentication right now.

from zulipbot.

@lonerz Eliminated the getIssueLabels function altogether in a5e1f7c and b13e0ed (although it's still in issueReferenced.js), since we can just get the issue labels from the responses and payloads themselves :)

Also, there's only one instance of getLabels (the function that gets the repository labels), and one each of removeLabel and replaceAllLabels, should we really look into eliminating those "duplicate" functions?

from zulipbot.

@synicalsyntax those require .then() which means that we'll have to look into async functions...

from zulipbot.

@synicalsyntax I went through all the code and I think we got rid of all the duplicate functions. Closing for now.

from zulipbot.