Update first message ID when first message is deleted about zulip HOT 22 CLOSED

This may be tricky; I'm not sure. do_delete_messages probably just needs to check the stream containing the deleted messages, if any, and just do a quick query to check if its first_message_id is stale, and if so, update it.

It is reasonably likely that doing that change will cause a test in test_events for deleting messages to fail -- because we're not sending an event to notify existing clients of the new value. Whether it not that happens, we ideally would send an event op="update" event for the first_message_id property to live-update clients.

The manual test case to verify this is working is that "more topics" should no long incorrectly appearing if you create a new stream, send a message, and then delete the first message (to "stream events") that had been sent to that stream.

from zulip.

Yes, "more topics" is expected when you have muted topics (i.e., there are more topics to show).

from zulip.

Hello @zulip/server-message-view members, this issue was labeled with the "area: message-editing" label, so you may want to check it out!

from zulip.

@zulipbot claim

from zulip.

I couldn't reproduce the issue
here's how I have tried:

1. Create new stream.
2. Send a message to "stream events".
3. Delete the first message that i had sent to "stream events" or delete the message fist messsage sent by bot in "stream events".
   Screencast from 10-02-24 10:41:32 PM IST.webm

from zulip.

While working on #28941 , I got to see "more topics" appears up after following steps.

1. Mute any of the topic of particular stream.
2. Click on any other topic, "more topics" appears.

I just want to confirm if it's a desired behaviour ?

from zulip.

@zulipbot abandon

from zulip.

@zulipbot claim
@alya I want to work on this

from zulip.

Welcome to Zulip, @rohit-sharma-1802! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

from zulip.

@zulipbot abandon

from zulip.

@zulipbot claim

from zulip.

Welcome to Zulip, @UdaySagar-Git! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

from zulip.

Hey @alya , I'm currently having trouble reproducing this issue. Could you please provide detailed steps on how to replicate it?

from zulip.

@UdaySagar-Git please take a look at the Zulip contributor guide, and keep in mind the following guideline:

Before you claim an issue, you should be confident that you will be able to tackle it effectively.

I will go ahead and unassign this issue, and you should feel free to re-claim it once you have figured out how to approach it (or pick a different one if you prefer).

from zulip.

I have updated the issue description to hopefully be more clear.

from zulip.

@zulipbot claim

from zulip.

Welcome to Zulip, @Epik-Whale463! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

from zulip.

@Epik-Whale463 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

from zulip.

hey @alya , if the issue is not resolved, i can fix this....
@zulipbot claim

from zulip.

Welcome to Zulip, @Thanush19! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

from zulip.

@Thanush19 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

from zulip.

@zulipbot claim

from zulip.