Create UserMessage rows for outgoing webhook and embedded bots about zulip HOT 4 OPEN

Hello @zulip/server-bots members, this issue was labeled with the "area: bots" label, so you may want to check it out!

from zulip.

I think it feels like a bug not creating UserMessage rows for outgoing webhooks given how we mentioned that it should behave just the same as a generic bot, so I agree with the direction of fixing that.

#18117 went down the "modifying has_message_access path", but in hindsight, it is more appropriate to create UserMessage rows to reduce the hassle of special-casing.

At the moment, I'm not sure if there is much need for the limited outgoing webhook bot type, if the CZO issue brought to our attention is just about reacting to DMs, which can be resolved with the proposed fix in this issue.

I guess it will be more beneficial if we have a bot-agnostic access control system for API tokens so that we can make it configurable in the UI. This will end up being more generalized than the "allow_incoming_webhooks" approach. If we take the time to design this properly, it should be pretty easy to compose presets of access control configuration to create things like a limited outgoing webhook bot.

from zulip.

@prakhar1144 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

from zulip.

I'll pick this up tomorrow.

from zulip.