Inline IME about notepad2 HOT 12 CLOSED

@maboroshin I don't see the PR.

from notepad2.

@bluenlive Very sorry to bother you, can you help us to resolve inline IME issue on Scintilla at
https://sourceforge.net/p/scintilla/bugs/2038/?

from notepad2.

@bluenlive Thank you, I will revert the changes to Korean IME, so it will inlined by default and use block caret by default.

from notepad2.

@zufuliu There was small miscommunication. I and jhonsonj are different person. ^^
And, for now, I didn't find any problem with IME.

from notepad2.

jhonsonj joined in our discussion yesterday, I thought you had contact her.

Current master code indeed contains broken changes to Korean IME, which I think need been reverted.

What I still unsure is that:
Whether Korean people use block caret in all Roman, Hangul and Hanja mode or not. If some mode don't use block caret, then it's better to make that mode configurable. Current implementation (hard-coded in Scintilla) use block caret for all modes.

from notepad2.

As I know, EVERY, ABSOLUTLY EVERY Korean uses and likes block caret mode.
I and my friend say "very old style, something like in Windows 3.1 era" about SC_IME_WINDOWED state.

Thank you, always.

from notepad2.

@bluenlive thank you. I will extend Scintilla to add an option to configure inline IME block caret.

from notepad2.

Option added in 300590c.

Inline IME and block caret for inline IME is default enabled for Korean IME.

from notepad2.

I built it and confirmed it. (View > Caret style, Settings > Use Inline IME) I also make Japanese patch for Notepad 2. The next release will be powerful.

from notepad2.

The unpleasant change to Korean IME is reverted. 5bf3df1
Korean IME reverted back to always use inline mode and use block caret in inline mode without any settings, i.e. hard-coded inside Scintilla.

I'm sorry for the change.

from notepad2.

All right. Thank you for your work.
C programming is difficult for me.

from notepad2.

@maboroshin There are still changes to candidate window position (the change is still not complete, see https://sourceforge.net/p/scintilla/feature-requests/1300/), can you test whether last build still works for Japanese IME in inline mode?

https://ci.appveyor.com/project/zufuliu/notepad2
https://ci.appveyor.com/api/buildjobs/sb6sdgb7yduagkh7/artifacts/build%2FNotepad2_x64_v4.19.06r2148.zip
https://ci.appveyor.com/api/buildjobs/ockxekfrhu37ur8g/artifacts/build%2FNotepad2_Win32_v4.19.06r2148.zip

It's possible, based on Chromium's source (BSD 3-Clause), Google IME can be fixed.
https://github.com/chromium/chromium/tree/master/ui/base/ime/win

from notepad2.