Better antigen support about zsh-history-substring-search HOT 8 CLOSED

@desyncr Thanks for clarifying. 👍 Antigen users should just configure their keybindings (as described in step 2 of the "Usage" section in the README) after activating this plugin; it's only 2 extra lines of code. 😱

antigen bundle zsh-users/zsh-history-substring-search
# configure your keybindings here... just 2 lines of code!
bindkey '^[[A' history-substring-search-up
bindkey '^[[B' history-substring-search-down

These keybindings aren't performed automagically (as the OP requests) when you load this plugin because:

• The user should have full control over how they want to use this plugin (and through which keys). 🖐️
• We haven't found a universal way of specifying keycodes for the up and down arrow keys, which is why step 2 of the "Usage" section in the README has several ways of binding them: $terminfo[kcuu1] vs $terminfo[cuu1] vs ^[[A so there is no "one ring to rule them all" 💍 way that Just Works.

from zsh-history-substring-search.

@aramboi Thanks for confirming. 👍 Here's a final example for Antigen users:

antigen bundle zsh-users/zsh-history-substring-search
antigen apply

# zsh-history-substring-search configuration
# (put whatever configuration you want here!)
bindkey '^[[A' history-substring-search-up
bindkey '^[[B' history-substring-search-down
HISTORY_SUBSTRING_SEARCH_ENSURE_UNIQUE=1
# and more... see the README for information

Case closed. 📕

from zsh-history-substring-search.

@marco-lavagnino, what is missing do you think? Can you be more concrete? Is it correct the only thing you need is the keybindings?

from zsh-history-substring-search.

@Tarrasch This may be related to the removal of the .plugin.zsh file as discussed in #48 and https://github.com/zsh-users/zsh-history-substring-search/pull/49/files.

@marco-lavagnino's description sounds like Antigen is looking specifically for a plugin.zsh file and not checking for *.zsh

from zsh-history-substring-search.

@Tarrasch @marco-lavagnino may correct me but yes, the issue is with keybindings.

@unixorn Antigen has no issues with or without plugin.zsh, it will look for *.zsh and load it.

from zsh-history-substring-search.

The bindkey lines above should be added after antigen apply in order to work.
Thanks for explaining this issue in detail @sunaku.

from zsh-history-substring-search.

bindkey '^[[A' history-substring-search-up
bindkey '^[[B' history-substring-search-down

Which keyboard key combinations will this map to?

from zsh-history-substring-search.

Which keyboard key combinations will this map to?

arrow up and arrow down.

from zsh-history-substring-search.