Git Product home page Git Product logo

Comments (9)

tnajdek avatar tnajdek commented on June 11, 2024

This poses a problem as currently embedded version does not include bootstrap. We could:

  • Add bootstrap, but I would really rather not, especially that to get modals we would also require jQuery which would completely bloat the size of the package
  • Implement (or find third-party) lightweight modal windows library
  • Split presentation from logic completely (it's mostly done already anyways) and produce separate builds: one as it is currently tailored for embedding on other pages, and another one with dependency on bootstrap and jquery for use on zotero.org

I'm leaning towards the last option, but would love to hear your opinions/thoughts @dstillman @johanneskrtek @fcheslack

from publications.

stakats avatar stakats commented on June 11, 2024

If we went with the last option, could we offer some lightweight presentation code to be downloaded and used with the embedded version, e.g. for people to test implementation?

from publications.

flachware avatar flachware commented on June 11, 2024

I'm little in the dark with regards to the motivation of this revision. @dstillman could you elaborate on the problem that could rather be addressed with a modal than with the expandable sections?

In terms of the visual appearance I would say that modals tend to fit better to a web apps whereas expandable sections are often seen components on web pages. That's why I think the modal would integrate more seamless on zotero.org than in the library for external host pages.

from publications.

tnajdek avatar tnajdek commented on June 11, 2024

@stakats certainly, I was planning to host a static demo on github pages once publications feature goes public.

from publications.

dstillman avatar dstillman commented on June 11, 2024

Well, at this point I'd just like to see how the interaction compares to the accordion on the profile page β€”Β the Bootstrap suggestion was just because (I think) we have it on z.org and it supports modal dialogs. But yes, if we went this route, separate builds make sense.

Motivation for trying this is just that the accordion seems a little weird to me after trying it on the profile page: that it pushes the footer down (though that could be helped by a less-prominent footer), that it disrupts the layout of the page in general, that you end up with an awkward web-app-y drop-down in the middle of the webpage (though that could be helped by a different interaction model for the Cite/Export stuff), and that you can open more than one at once, resulting in multiple web-app-y drop-downs (though that could be helped by making the accordion modal).

I also think we may actually want to put more info in the details view, which could make the accordion even more disruptive. I don't know if this will work either, but I think it's worth trying. An obvious model here is Twitter, where clicking on a tweet opens a modal popup with the detail view.

from publications.

tnajdek avatar tnajdek commented on June 11, 2024

Ok, I'm happy to work on a quick POC for look-and-feel purposes only. We can then keep it if it feels right (in which case I'll work on separate builds etc.) or throw it away.

Sounds like a plan?

from publications.

dstillman avatar dstillman commented on June 11, 2024

Yeah, that sounds great β€” thanks!

from publications.

flachware avatar flachware commented on June 11, 2024

Yes, let's give it a try! If we have separate builds, this could work out as Bootstrap 3 modals work pretty well.

I would advise against the modal for the embedded version, as it freezes the viewport which might be considered intrusive.

Now that we are talking about separate builds we could even reactivate the original concept of a separate publication list and details view, which might be handier on mobiles.

from publications.

tnajdek avatar tnajdek commented on June 11, 2024

Preserved in a branch modals

from publications.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.