package com.facebook.react.modules.permissions does not exist about react-native-permissions HOT 14 CLOSED

I guess you need at least RN 0.29 where Android permissions was introduced, it may be good to add the info in the README.

from react-native-permissions.

reopened so I don't forget to update the readme

from react-native-permissions.

thanks for updating the readme, @KGALLET!

from react-native-permissions.

@ekryski - Hey dude, thanks for the explanation. I didn't realize that npm treated <1.0.0 and >=1.0.0 differently. Will definitely follow this rule going forward!! thanks again 🍻

from react-native-permissions.

Ok, updating to RN 0.30 solve my problem.
Thx @vincentfretin @yonahforst :)
Closed.

from react-native-permissions.

Getting this on RN 0.31.0, any tips?

from react-native-permissions.

Hrmmm. I was lazy and used an undocumented API 😱 . It probably changed in 0.31.0, I'll have a look.

from react-native-permissions.

Probably it is my fault since my android project uses older RN version than the version installed from npm (how this is even possible?), but thanks for checking anyway :)

from react-native-permissions.

Ok, no problem. I checked anyways and looks like the API hasn't changed. Closing the issue back out.

from react-native-permissions.

FWIW it probably should have been a minor release, since this has a breaking change. Anyone on a version of RN < 0.29.0 had it installed on an npm install.

from react-native-permissions.

@ekryski thanks for bringing this up. I wasn't sure if I did the version numbers right, so I really appreciate feedback here.

Android wasn't supported on previous versions so I didn't think adding it would be considered a breaking change. The old API still works but has deprecation messages. That's why I did it as a minor release (0.1.x -> 0.2.x is minor, right?). Or did you mean it should have been a major release.

Also, what do you mean here:

Anyone on a version of RN < 0.29.0 had it installed on an npm install.

Thanks for educating me on this 🙏🏽

from react-native-permissions.

@yonahforst no problem bud. With npm, minor releases < 1.0.0 (ie. 0.1.0) won't get automatically installed. Patch releases will (ie. 0.1.1).

Above 1.0.0 only major releases won't be installed automatically, minor and patch releases will.

So if you are < 1.0.0 (which is totally fine especially in RN because shit is changing so much) then just do a minor release for breaking changes. With feathers we don't bump to a 1.0 until we feel like it is "stable". A bit wishy-washy but it's been working well for us so far.

Android wasn't supported on previous versions so I didn't think adding it would be considered a breaking change.

I totally understand. How the hell are you supposed to know? Definitely no blame here. The issue was that doing an npm install, brought in references to Facebook's permissions in the Android gradle files, and unless you are v0.29+ of RN it just blows up compiling. So you wouldn't see it if you are only running RN on an iOS device.

Hope that explains things! Really appreciate the hard work! 😄

from react-native-permissions.

I'm having this problem too.
npm list say that I'm using RN v0.32.1

from react-native-permissions.

I have the same issue, RN v0.36.

from react-native-permissions.