Translation stuff done, please pull in and test... about zoneminder HOT 13 CLOSED

Hey there. Sorry for asking again, but which of your many pull requests should I be using? :) Could you give me specific pull request numbers?

Thanks,
Kyle

from zoneminder.

You should pull in all of them. I've immediately closed the ones I withdrawn, thus the active pull requests from me are all valid:

#44, #49, #50 (don't know the purpose of the separate .in file, if it's used, pull #50 in too), #51, #53, #55, #56, #58, #59, #60, #61, #65, #66, #67, #69, #70, #74

One note: there's quite a couple of new localizable strings available now, I've added them to English and Hungarian. How to add these to the other languages? Should I send a pull request for each language file, with the strings added in English? Also there are lots of ".orig" files in the language directory, what to do with these? Do these need to be updated too?

from zoneminder.

Kyle, were these pulled in or not? I got notifications that they were closed by Kfir Itzhak, I see that the 'develop' branch disappeared, but I don't see my work in 'master' either.

from zoneminder.

It doesn't look like these got pulled in. When @mastertheknife merged develop into master and deleted the develop branch, it looks like that auto-closed your requests.

When I have some more time I'll see if we can still merge these in manually.

from zoneminder.

OK thanks I really hope I didn't work in vain.

from zoneminder.

@nagyrobi and @kylejohnson
Can this issue be closed?

from zoneminder.

I would close it only after merging my changes to the main.

I've spent many days of work on these, and seems somebody just deleted them with a single click. I'd be happy to at least know somebody took the time to review them one by one and decide if can be merged or not.

from zoneminder.

@nagyrobi I'm sorry your work didn't get merged into the source tree. After reading through this thread, I'm sure it was not intentional.

@kylejohnson
Where you ever able to determine how we can get all of @nagyrobi closed pull requests re-opened and merged??

from zoneminder.

@nagyrobi I'm not sure if you are subscribed to issue #315 but it looks like you are going to have to re-open all those pull requests against the master branch. My apologies. It looks like the branches in your fork that were used to previously generate the pull requests are still there, so I hope this isn't too big a deal.

It would be nice to get your work into the next release, which we are currently testing.

from zoneminder.

@nagyrobi We are getting ready to release 1.27. Can you re-open all those pull requests against the release-1.27 branch?

from zoneminder.

@nagyrobi It would be /much/ better if you could open a single pull request with all changes.

from zoneminder.

I'm not sure if I'm able to send them all in as a single pull request.
Plus, all I currently have is a 1.25.0 system installed on ubuntu from repository. In order for my mods to be tested against the new 1.27 I have to deploy myself a new test environment, which takes time.
Is there a deadline to release 1.27?

from zoneminder.

@nagyrobi
Please review and provide your feedback to pull request #333

from zoneminder.