Git Product home page Git Product logo

Comments (8)

alexyao2015 avatar alexyao2015 commented on September 24, 2024 1

I can go ahead and test this. I don't run zoneminder and as a result, this package, so I haven't noticed anything.

from zoneminder-base.

alexyao2015 avatar alexyao2015 commented on September 24, 2024

Not sure what you're talking about. That screenshot shows a build from the most recent zoneminder commit. Looks like it's working fine to me.

from zoneminder-base.

Simpler1 avatar Simpler1 commented on September 24, 2024

No commits since about June 14th are in the nightly-1234 environment.

Look at line 286 of /var/www/html/skins/classic/views/js/event.js
In the zoneminder master, it is:
setCookie('zmEventScale'+eventData.MonitorId, scale);

but in the nightly-1234 environment, it is:
setCookie('zmEventScale'+eventData.MonitorId, scale, 3600);

That's just one example.

from zoneminder-base.

Simpler1 avatar Simpler1 commented on September 24, 2024

Zoneminder moved to 1.37.41 on July 12th, but the nighly is still showing 1.37.40.

from zoneminder-base.

alexyao2015 avatar alexyao2015 commented on September 24, 2024

That's probably something wrong with zoneminder then. You should consider reporting this to zoneminder if you believe their builds are broken. It's impossible for it to be building the wrong version since it just pulls from git directly. Nothing special is going on.

&& git clone https://github.com/ZoneMinder/zoneminder.git . \

from zoneminder-base.

Simpler1 avatar Simpler1 commented on September 24, 2024

If I run:
git clone https://github.com/ZoneMinder/zoneminder.git .
and then check the file above, line 286 has the correct change.
also git log, shows all of the commits.

These commits are not in the nightly-1234 environment. Do you see them in the nightly-1234 environment?

from zoneminder-base.

alexyao2015 avatar alexyao2015 commented on September 24, 2024

Looks as expected to me. I would suggest clearing your docker image cache.

@alexyao2015 ➜ /workspaces/zoneminder-base (main) $ docker exec -it zoneminder-base-zoneminder-1 /bin/bash
root@66fd189eb89a:~# cd /var/www/html/skins/classic/views/js
root@66fd189eb89a:/var/www/html/skins/classic/views/js# sed -n 284,290p event.js
    alarmCue.html(renderAlarmCues(eventViewer));
  }
  setCookie('zmEventScale'+eventData.MonitorId, scale);

  // After a resize, check if we still have room to display the event stats table
  onStatsResize(newWidth);
} // end function changeScale

from zoneminder-base.

Simpler1 avatar Simpler1 commented on September 24, 2024

I've been debugging this myself and was just about to close this issue when you did.

In order to add vim to the zoneminder container, in the docker-compose.yaml file I changed
image: ghcr.io/zoneminder-containers/zoneminder-base:nightly-1234
to
build: .

and then added the following Dockerfile to the directory:

FROM ghcr.io/zoneminder-containers/zoneminder-base:nightly-1234
RUN apt-get update && apt-get install -y vim

For some reason, that does not honor the nightly-1234 tag and does not update.

Thank you for looking into this. I'll try to figure out why the build command does not update properly.

from zoneminder-base.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.