Git Product home page Git Product logo

Comments (7)

codebling avatar codebling commented on July 4, 2024 2

@krisklosterman thanks for all of the work you've done on this, but in the end I used @PhearZero's fork. Your commit history pretty messy and it's very hard to know what exactly has been done, and from the changes I saw in the diffs of a few commits, it looks like a lot of unnecessary changes have been made. Since there are no unit tests, it's hard to know whether the original functionality is still intact. Please please use a working branch for your changes and rebase out the useless commits when you're finalising everything.

Phear's fork looks great, the only changes made are the Nan ones (the only ones required to migrate to newer versions of node). @ayoubserti made basically the same changes in his fork but also altered the packages details and created a new npm module so it's easier to branch from Phear's fork.

I've fixed Windows compilation on my fork, and I've added Node 8 to Travis and also included a run on Appveyor.

from node-multi-hashing.

krisklosterman avatar krisklosterman commented on July 4, 2024

I can't get this to pull into node-stratum-pool....
tried changing the dep repo, tried adding it as a local repo, always gives me errors...

from node-multi-hashing.

krisklosterman avatar krisklosterman commented on July 4, 2024

Got it to pull into node-stratum-pool, removed a comment from the package.json

from node-multi-hashing.

krisklosterman avatar krisklosterman commented on July 4, 2024

got it to compile with nomp also, waiting to test hashing functionality with nomp with updated version

from node-multi-hashing.

PhearZero avatar PhearZero commented on July 4, 2024

Hey check out zone117x/node-cryptonote-pool#183 and #42 with everything converted to nan and building on all current node LTS. https://travis-ci.org/PhearZero/node-multi-hashing

from node-multi-hashing.

krisklosterman avatar krisklosterman commented on July 4, 2024

My fork is updated and tested to version 8.3.X, I am turning up a production pool here in the next week with my fork, will hopefully be a true test against the updates to node 8.3.x

from node-multi-hashing.

krisklosterman avatar krisklosterman commented on July 4, 2024

My fork is working good, the only issue is the c code for scryptjane is not compiling, its disabled at this time. I am also going to work in the future on getting equihash supported.

from node-multi-hashing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.