Git Product home page Git Product logo

Comments (4)

Zolko-123 avatar Zolko-123 commented on June 2, 2024
  1. I am seeing duplicated items. Is this by choice?

No. I've seen that too, but I don't know where it comes from. I hoped you would find the mistake

  1. I believe this is not an intended behavior, can you confirm?

this comes probably from if obj1.isDerivedFrom('Part::Feature') . This was intended to also take fasteners into account. May-be a bad choice after-all. Dunno, what do you think, should fasteners also be checked for interference ? For the time being, I'll revert to check App::Link only

from freecad_assembly4.

Zolko-123 avatar Zolko-123 commented on June 2, 2024

Also, there is something I don't understand: you make all the intersections (make_intersection), and then you remove those that are empty (remove_empty_common). Why not ignore from the beginning empty intersections ?

from freecad_assembly4.

leoheck avatar leoheck commented on June 2, 2024

No. I've seen that too, but I don't know where it comes from. I hoped you would find the mistake

I see, I will try to find the issue then.

May-be a bad choice after-all. Dunno, what do you think, should fasteners also be checked for interference ? For the time being, I'll revert to check App::Link only

I would like to have the fasteners tested too. The user could ignore them when inspecting visually since everything is transparent. I would just not include them if this becomes processing intensive.

I have a pretty good machine and maybe small assemblies. So far I did not have any issues regarding the processing taking too much time. I also was thinking to generate each intersection with threads, but I am not sure how to make this yet. Also, being able to abort the operation would be interesting. Do you know anything about using threads with Freecad?

Also, there is something I don't understand: you make all the intersections (make_intersection), and then you remove those that are empty (remove_empty_common). Why not ignore from the beginning empty intersections ?

I added this "remove when empty" some days later to avoid having too many objects created. My code definitely needs refinement. Maybe this is such a thing that can be tweaked.

from freecad_assembly4.

leoheck avatar leoheck commented on June 2, 2024

I am closing this topic since I've pushed some commits to improve the Interference Check.

from freecad_assembly4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.