Comments (17)
I just downgraded from 0.24.0 to 0.22.1 and this issue disappeared. There is a bug in the 0.24.0 version
from grammarly.
Hope this gets fixed soon.
from grammarly.
Same here. I Downgraded to v.0.23.10, and it's all good now. Hope this will fixed in the next release
from grammarly.
Still happens here too
from grammarly.
I am encountering this issue, too, and I would love to see it fixed. Thank you!
from grammarly.
That, I don't know. The Grammarly account is probably owned by @znck. So he may have insights about it.
EDIT:
It's honestly surprising that it still works...
from grammarly.
I doesn't change from American even when I set it to Australian, Canadian, ...
from grammarly.
After downgrading, the extension started to report "failed to connect to language server" and stopped working. I've had to re-install latest version and the dialect changes are being ignored again
from grammarly.
Is there any fix to this?
from grammarly.
I am pretty stupid when it comes to JavaScript, let alone VSCode extensions. So I am not able to fix it 😕
from grammarly.
Also coming across this, would love it for be fixed!
from grammarly.
Worryingly, I switched to the pre-release version v0.25.0 and the issue is still present. Hopefully, this can be fixed before the proper release of the next version.
from grammarly.
While looking into this, I realized that Grammarly has shut down their developer SDK as explained on the website: "Grammarly for Developers and the Text Editor SDK were discontinued on January 10, 2024" (https://developer.grammarly.com/).
So, this extension may work correctly and Grammarly may not. In any case, this is a real bummer...
@znck, Do you have more information or ideas for the future or this extension?
from grammarly.
Maybe it has to do with this?
from grammarly.
Maybe it has to do with this?
This seems to be the default. If 'result?.config' contains the dialect it will "overwrite" the default. If, for some reason, the dialect is not in the 'result?.config' it will of course always use the American dialect. Just note my previous comment. It might not be the code at fault.
from grammarly.
Interesting. But how come the American spelling is the only one still supported though, whilst ignoring the documentDialect property?
from grammarly.
After git diffing versions 0.24.0 and 0.22.1, it looks like the main changes that could potentially be related to this issue are on the ConfigurationService.ts file and the Grammarly SDK version in packages/grammarly-languageclient/package.json
In ConfigurationService.ts, it seems to me that all the properties from config except documentDialect are being included in DocumentConfig, which might be the reason why the chosen dialect is being ignored. However I'm not very experienced in TS syntax so I'm not sure if this is case.
const options: DocumentConfig = {
documentDialect: 'american',
...result?.config,
}
This might fix it.
const options: DocumentConfig = {
...result?.config,
}
// Use the user's settings if it contains documentDialect and otherwise default to "american".
options.documentDialect = options.documentDialect ?? 'american';
from grammarly.
Related Issues (20)
- Failed to parse URL... Invalid URL... HOT 4
- Cursor support needed HOT 1
- High Code Renderer GPU usage
- Language client is not ready yet HOT 3
- Investigate: Use internal API instead of Developer API HOT 1
- Setting to remove passive voice does not work as described
- Question: data privacy
- Feature: Extension ignores anything within the code fences
- Feature: support markdown definition lists
- I am not able to use any commands
- Ignore Latex comments HOT 3
- Grammarly SDK has been deprecated HOT 3
- remove check for verbatim in latex documents
- TeX non-breaking space
- Ability to turn check _off_ by default HOT 3
- With VSCoidum can't log into Grammerly Account
- Writing language preference HOT 3
- feature request: possible to right click my sentence, select "improve it" by grammarly ?
- vsCode extension does not work with Cursor
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grammarly.