Git Product home page Git Product logo

Comments (2)

psychon avatar psychon commented on June 12, 2024

So you want the OnQuit() hook to call Process() for each channel that the user is in instead? That would cause *watch to relay that message once for each channel which is bad, too.

from znc.

MomDad avatar MomDad commented on June 12, 2024

Even in watch module's own help description for SetSources, it says "Set the source channels that you care about." If I set it to a specific channel, clearly I don't care about Quit's from all the other channels I'm in. Yet, that's exactly what it does, and I end up with a target window constantly spammed with tons of Quit messages from every single user that quits any of the channels that I'm in.

Perhaps it's better articulated by a screenshot with a concrete example of what happens: http://i55.tinypic.com/ji1doz.png

onJoin, onPart, onKick, each pass the Channel.GetName() arg to Process(), yet onQuit just gets passed an empty string. Even if it does relay it for every channel it occurs it, it's better to filter/suppress that, than to let it through when you've specifically set a channel source.

from znc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.