Git Product home page Git Product logo

Comments (5)

zmilla93 avatar zmilla93 commented on September 24, 2024 1

Turns out that switching the game's language setting switches the @To and @From part of whispers to said language (IE @An and @Von in German), which isn't something I was aware of.

This should be a relatively easy fix, but since SlimTrade currently supports trade messages in 8 languages I'll take the time to fix this for all languages rather than just hot fixing for German.

Thanks for the report! Except this change in the next version, and sorry for the inconvenience in the mean time.

from slimtrade.

Xorjo avatar Xorjo commented on September 24, 2024

Hi zmilla93,
I had the same issue with the language. I managed to fix it for me at the moment unitl you release a new version, by changing hardcoded the to and from in ChatParser#getMessageType and in the References#REGEX_CLIENT_PREFIX. Of course this is not a fix to support multi languages.
Additionally I had to change the pattern in LangRegex for German. In my messages in the Client.txt I have no apostrophe around the (?<league>.+) and no points after (?<stashX>\d+) and (?<stashY>\d+) and no point at end after von oben\\).

from slimtrade.

zmilla93 avatar zmilla93 commented on September 24, 2024

Sorry about the delay, and thanks for the additional info. I just published a prerelease of the next version with the language changes only. It would be awesome if you could verify this is working correctly before I release the full version since I don't have an easy way to test.

Prerelease Download

If either of you want to help me out long term and you receive trade messages in German (based on preferred language on pathofexile.com), you could tell me your account name (displayed on website, not a character name). This will then let me use the trade website to generate trade messages in German so I can do proper testing myself. The translations were taken from an old reddit post from a few years ago, so I want to eventually clean them up myself once I have modern examples in all languages.

from slimtrade.

Xorjo avatar Xorjo commented on September 24, 2024

I have made some trades right now. Incoming and outgoing seams to work well with the new prerelease version. The history was loaded and updated correctly as far as I saw.

My prefered language in pathofexile.com is set to German and my account in poe is the name as it is here 'Xorjo'. You can use it to generate messages for testing.

from slimtrade.

zmilla93 avatar zmilla93 commented on September 24, 2024

Fixed in v0.2.9.

from slimtrade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.