Merging TLS1.3 master, now that zcrypto has about zgrab2 HOT 5 CLOSED

I haven't been particularly involved in TLS1.3. If it's in ZCrypto, and someone adds it into ZGrab (is there a PR?), I'd merge it.

from zgrab2.

I haven't been particularly involved in TLS1.3. If it's in ZCrypto, and someone adds it into ZGrab (is there a PR?), I'd merge it.

Great!

I'm happy to fix up any merge conflicts as a result of drift for the zgrab2 TLS1.3 branch and submit a PR

I'm time starved but it's the least I could do since I contributed practically nothing to the real TLS1.3 branch, aside from adding to/reordering the cipher-suites (for --cipher-suite portable) and proving a flag to flip a bit in the tls.config to allow early renegotiation (for --negotiate-freely)

Thanks

from zgrab2.

I've been on vacation the last several days, sorry I haven't chimed in yet! One thing holding up merging TLSv1.3 is feature parity with main. Some of the zcrypto TLS1.3 feature branch changes will cause feature regressions (for instance, lack of heartbleed support), so we'll want to address that prior to merging. I'm still traveling today so a bit out of pocket as far as specific details, but I'll try to compile a list this week of what I know to be the missing features needed for main (or if someone else does, that it great as well).

from zgrab2.

I've been on vacation the last several days, sorry I haven't chimed in yet! One thing holding up merging TLSv1.3 is feature parity with main. Some of the zcrypto TLS1.3 feature branch changes will cause feature regressions (for instance, lack of heartbleed support), so we'll want to address that prior to merging

This is exactly what I noticed, accidentally, with a PR to the wrong branch :>

I'm still traveling today so a bit out of pocket as far as specific details, but I'll try to compile a list this week of what I know to be the missing features needed for main (or if someone else does, that it great as well).

I'm always happy to pitch in but I'm exceptionally busy lately. Either way- would you like to track that in this issue? I can at least put together the high level info (I think) without too much effort

from zgrab2.

This happened a long time ago, thanks to those who worked on it!

from zgrab2.