Consider removing the `; $ADDR: $BY $TE` comments? about ladx-disassembly HOT 6 CLOSED

I'm in the other camp: I use these comments all the time, and wish they had even more information (banks)!

They're extremely useful for ROM hacking. I concede that the symbol file can replace some use cases, but they're especially useful for keeping a constant budget of bytes (for minimizing patch sizes).

from ladx-disassembly.

Oh, okay! Never mind then. :)

This is just my personal input! My use case may be very fringe.

Do you mean they're "extremely useful" for binary-hacking a ROM, using the disassembly just for reference? Or is LADX not yet fully relocatable, so you can't just insert/delete code and expect the rest to work even when shifted?

I use the disassembly itself for hacking (not binary hacking, although rgblink's --overlay option allows a middle ground), and it is fully relocatable. However, ROM hacks are distributed as patches that just contain the binary diff between the old ROM and the new. If there is major relocation in the new ROM, the patch will be big and (perhaps more importantly) it will contain the relocated parts, even the unchanged ones which are copyrighted.

As long as the disassembly maps one-to-one to the ROMs, I find it useful to have a view of both the code and the bytes side by side.

from ladx-disassembly.

Oh, okay! Never mind then. :) Do you mean they're "extremely useful" for binary-hacking a ROM, using the disassembly just for reference? Or is LADX not yet fully relocatable, so you can't just insert/delete code and expect the rest to work even when shifted?

from ladx-disassembly.

I'm also using these comments a lot, and even updated/added them where they where missing. They match the 1.0 EN rom perfectly, which is the default build. As LADXR is build around binary patching, I need to know the addresses for any patch. And yes, I would have loved to have the banks in the comments as well.

I also use them during reverse engineering to quickly jump to specific instructions to set breakpoints in bgb.

I understand how they can look "useless" but they are far from it for a bunch of us.

from ladx-disassembly.

as a personal note they're frustrating, because if you want to update or change something you not only have to make the change (say, updating or fixing code) but also then have to go back and adjust/fix all the comment lines or they look horrid

they also make adding simple end-of-line comments largely impossible if you want to keep line length bloat down

from ladx-disassembly.

We have a script to align those comments, it's in the repo.

from ladx-disassembly.