Git Product home page Git Product logo

Comments (4)

Yahui-Li avatar Yahui-Li commented on May 26, 2024

另外设置策略为ALL的话,隐藏的问题就是如果播放的数量太多,帧数又太多的话,8.0之前bitmap是放在java heap的,肯定比较容易溢出

from glidewebpdecoder.

zjupure avatar zjupure commented on May 26, 2024

@YouheiLee bitmap cache in webpdecoder has another function. When rendering an non-key frame, it is based on the nearest key-frame previous rendered and the cache will be useful. Otherwise we need render from last key-frame again to get current frame bitmap and performance will be low. And min cache size set to 5 with CACHE_NONE is a reasonable assumption that hit the cache to render a new frame with high possibility.
CACHE_ALL is just an option control to decide by app when you don't want to reuse glide cache. It is single request configuration and how to control memory usage is all totally decided by caller.

from glidewebpdecoder.

Yahui-Li avatar Yahui-Li commented on May 26, 2024

I think that we do not need cache bitmap with a specific number like 5. Consider that we have 20 frame in a webp image, cache 5 bitmap is useless, every time we will need obtain a new bitmap object from bitmap pool instead lru cache defined at WebpDecoder cause the right index will never be hit. So there are only two ways left: 1. only cache the last key frame; 2. cache all frame.

from glidewebpdecoder.

zjupure avatar zjupure commented on May 26, 2024

The cached bitmap was used to render current bitmap and right index not hit was expected. If current frame is not key frame, the decoded bitmap is not full. We must fill the canvas with previous frame data according to webp rendering principle. Only cache the last key frame is not suitable and might cause extra frame decoding.

For example, with a webp has 20 frame, and frame 1, 5, 10, 15 are key frames. Assume current frame index to render is 4, If you only cache the last key frame that means it is 1. To get the full bitmap of frame 4, we need decode frame 2, frame 3 again. Because frame 4 bitmap = frame1 + frame2 + frame3 + frame4. But if we cache frame 3 (non-key frame) and it meet the condition, and so we no need to decode frame 3 again, because frame 4 bitmap = frame3 + frame4.

@YouheiLee you should understand prepareCanvasWithBlending() and next for-loop. renderFrame() with native call might call many times without previous frame cache. And that is the main purpose of 5 cache. Why we not only cache the one frame before current frame, because sometimes it not always meet conditions in prepareCanvasWithBlending()

from glidewebpdecoder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.