Git Product home page Git Product logo

Comments (12)

angshine avatar angshine commented on May 30, 2024 2

Hi, sorry for the inconvenience, and thank you for your time! I have updated the code and tested the colab and demo_single_pair.ipynb results, and they all work appropriately now. Just make sure you use temp_buf_fix=True with the new ckpt. We will polish the logic in later releases.

from loftr.

howard5758 avatar howard5758 commented on May 30, 2024 1

Hi, I can confirm the provided colab work appropriately. Thank you so much for the help!

from loftr.

JiamingSuen avatar JiamingSuen commented on May 30, 2024

Hi @howard5758, a recent bug fix (3955e99 and #41) breaks the compatibility of the released model weights. We will fix this issue very soon and release the new models, thanks for the heads up.

from loftr.

howard5758 avatar howard5758 commented on May 30, 2024

Understood. Thank you so much for the quick response and the information :)

from loftr.

angshine avatar angshine commented on May 30, 2024

Hi, this issue has been fixed in the most recent commit.

from loftr.

howard5758 avatar howard5758 commented on May 30, 2024

Hi, thanks for the prompt actions.

I cloned the repo again and first encountered the following error:
loftr_error1
I removed the line "temp_bug_fix=config['coarse']['temp_bug_fix'])" and it still gave similar inference result as yesterday.
I then downloaded the new indoor_ds model you shared earlier, but saw a bunch of missing keys in state_dict and was unable to perform inference.
loftr_error2

Really appreciate your help :)

from loftr.

angshine avatar angshine commented on May 30, 2024

Hi @howard5758, can you share the script(mytest.py) and the config you are using? I think this relates to a misconfiguration of the project (e.g. mixing old & new files🤔).

from loftr.

howard5758 avatar howard5758 commented on May 30, 2024

Hi @angshine , mytest.py is basically the exact same code from demo_single_pair.ipynb
The only part I modified is commenting out "temp_bug_fix=config['coarse']['temp_bug_fix'])" in src/loftr/loftr.py
Currently the provided colab is still giving me the keyerror:
loftr_error3
Can you kindly double check the colab maybe then I can directly follow the steps there.
Thank you very much!

from loftr.

GabbySuwichaya avatar GabbySuwichaya commented on May 30, 2024

Hi! Just wonder if the new trained weight is updated ?

from loftr.

JiamingSuen avatar JiamingSuen commented on May 30, 2024

The updated weight is in the google drive folder here
image

from loftr.

GabbySuwichaya avatar GabbySuwichaya commented on May 30, 2024

Thanks! Such a good news. Are they all updated ? All the cases?

from loftr.

xmba15 avatar xmba15 commented on May 30, 2024

@JiamingSuen Can you also update outdoor_ds.ckpt? I still see the problem mentioned above with outdoor_ds.ckpt.

from loftr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.