Git Product home page Git Product logo

Comments (6)

ghostdogpr avatar ghostdogpr commented on June 15, 2024 1

They're not currently, just ran on a manual basis.

from zio.

ghostdogpr avatar ghostdogpr commented on June 15, 2024

Contribution would be welcome πŸ‘πŸ™

from zio.

eyalfa avatar eyalfa commented on June 15, 2024

Contribution would be welcome πŸ‘πŸ™

πŸ‘ do u happen to know if there's a way to run the benchmarks as part of the PR's CI?

from zio.

eyalfa avatar eyalfa commented on June 15, 2024

seems like ZChannel.Bridge is now only used by the ZChannel.mergeXXX family of functions, not really justified I might add.
these functions allow all merged channels to read from the same upstream, something similar to broadcast followed by merge, in fact most if not all stream operations involving merge operate on streams (one of the reason for introducing ZPipeline.fromFunction) so user's would have to work pretty hard to come up with code that utilizes the 'shared' upstream.

it's worth noting that the channel executor identifies this and skips the bridge in these scenarios.

so two questions here:

  1. do we want to introduce the mergeXXX functions on ZPipeline as well?
  2. can we completely deprecate the Bridge (I recall Adam stating on Discord he'd like to get rid of it), if so how do we replace and deprecate the ZChannel.mergeXXX family of functions which are currently public API

from zio.

ghostdogpr avatar ghostdogpr commented on June 15, 2024

Closed by #8761

from zio.

ghostdogpr avatar ghostdogpr commented on June 15, 2024

Since Bridge is private to zio, I think we could potentially delete if we replace its current usage by something else, but all public API need to remain.

from zio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.