Comments (9)
Ah ha - and then the update column becomes clickable to update on demand! =)
from youtube-fast-fullscreen-toggle.
Fixed in 2.5.0. The new version has been submitted to the Chrome Web Store for review; in the meantime, the latest version can be used in Tampermonkey.
from youtube-fast-fullscreen-toggle.
Ooh, it looks like the update setting needs to be enabled per script:
from youtube-fast-fullscreen-toggle.
@ZimbiX Oh wow, I had no idea ... how on earth could I have missed that option??? 😖
The way to manually trigger an update either by clicking the "last updated" text or by selecting a script and choosing Trigger Update from the dropdown is not exactly super-intuitive. I believe I tried the latter option (dropdown) but unless the script setting is enabled it will fail no matter.
Thanks a lot for finding this! 👍
from youtube-fast-fullscreen-toggle.
Interesting. Thanks for the info; I'll look into it when I have time
from youtube-fast-fullscreen-toggle.
It seems that YouTube doesn't do a regular page load when you navigate around the site; instead doing something similar to turbolinks, where it swaps out the page content. Thus the extension (and when run in Tampermonkey) does not re-run after navigating to another page. For example, starting from the watchlist page, then clicking on the first video. It does appear to still work when navigating from one video to another; I guess in that case, the DOM elements which had listeners attached when the extension first ran are reused.
I'm looking into something like's jQuery delegate - to dynamically handle an event based on a particular CSS selector, allowing it to apply to new DOM elements too.
from youtube-fast-fullscreen-toggle.
Or alternatively, I could use window.onurlchange
to listen for URL changes.
from youtube-fast-fullscreen-toggle.
Awesome, thanks for the fix, I just tested and now it triggers on every video 👍
I didn't think of just changing the match to youtube.com/*
but apparently there was other code changes needed too.
By the way would it be possible to add a header to make it auto-update when using a user-script directly from Git or would you have to upload to Greasyfork or similar? I mean the downloadURL
should be enough right? Or maybe you have to add a updateURL
header too.
from youtube-fast-fullscreen-toggle.
No problem. I'd noticed something weird was happening sometimes; thanks for the motivation to look into it!
I haven't made use of userscript auto-updating before. I didn't see much useful official documentation, but I followed this great StackOverlow answer. As far as I can tell, it should work, but I haven't yet observed Tampermonkey performing an update. I notice that Tampermonkey's settings page has two different update interval settings - I'm not sure which would apply here, but the options are not very granular:
I think I'd prefer not to upload it to a site like Greasyfork if I don't have to, as it's another thing I'd have to maintain. I don't know that user discovery would benefit that much from it.
I mostly use it in the extension form myself, to reflect the experience of how I imagine most people will be using it. I'll try switching to Tampermonkey and decreasing the version number to try to see it perform an update.
from youtube-fast-fullscreen-toggle.
Related Issues (10)
- Bug: F key interrupts typing search/comment
- F key does not trigger fast transition HOT 1
- Not working on Vivaldi HOT 4
- Handle double-clicking video HOT 2
- Handle leaving fullscreen with Escape and toggling with F11 HOT 2
- Release v2.3.0 HOT 1
- v2.3.1 CRX is slow to leave fullscreen
- Scrollbar appears for a few seconds after entering fullscreen HOT 2
- Remove console.log in the production code
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from youtube-fast-fullscreen-toggle.