Git Product home page Git Product logo

Comments (9)

ZimbiX avatar ZimbiX commented on June 15, 2024 2

Ah ha - and then the update column becomes clickable to update on demand! =)

Screenshot from 2021-06-05 17-13-44 - annotated

from youtube-fast-fullscreen-toggle.

ZimbiX avatar ZimbiX commented on June 15, 2024 1

Fixed in 2.5.0. The new version has been submitted to the Chrome Web Store for review; in the meantime, the latest version can be used in Tampermonkey.

from youtube-fast-fullscreen-toggle.

ZimbiX avatar ZimbiX commented on June 15, 2024 1

Ooh, it looks like the update setting needs to be enabled per script:

Screenshot from 2021-06-05 17-10-31

from youtube-fast-fullscreen-toggle.

Pathduck avatar Pathduck commented on June 15, 2024 1

@ZimbiX Oh wow, I had no idea ... how on earth could I have missed that option??? 😖

The way to manually trigger an update either by clicking the "last updated" text or by selecting a script and choosing Trigger Update from the dropdown is not exactly super-intuitive. I believe I tried the latter option (dropdown) but unless the script setting is enabled it will fail no matter.

Thanks a lot for finding this! 👍

from youtube-fast-fullscreen-toggle.

ZimbiX avatar ZimbiX commented on June 15, 2024

Interesting. Thanks for the info; I'll look into it when I have time

from youtube-fast-fullscreen-toggle.

ZimbiX avatar ZimbiX commented on June 15, 2024

It seems that YouTube doesn't do a regular page load when you navigate around the site; instead doing something similar to turbolinks, where it swaps out the page content. Thus the extension (and when run in Tampermonkey) does not re-run after navigating to another page. For example, starting from the watchlist page, then clicking on the first video. It does appear to still work when navigating from one video to another; I guess in that case, the DOM elements which had listeners attached when the extension first ran are reused.

I'm looking into something like's jQuery delegate - to dynamically handle an event based on a particular CSS selector, allowing it to apply to new DOM elements too.

from youtube-fast-fullscreen-toggle.

ZimbiX avatar ZimbiX commented on June 15, 2024

Or alternatively, I could use window.onurlchange to listen for URL changes.

from youtube-fast-fullscreen-toggle.

Pathduck avatar Pathduck commented on June 15, 2024

Awesome, thanks for the fix, I just tested and now it triggers on every video 👍
I didn't think of just changing the match to youtube.com/* but apparently there was other code changes needed too.

By the way would it be possible to add a header to make it auto-update when using a user-script directly from Git or would you have to upload to Greasyfork or similar? I mean the downloadURL should be enough right? Or maybe you have to add a updateURL header too.

from youtube-fast-fullscreen-toggle.

ZimbiX avatar ZimbiX commented on June 15, 2024

No problem. I'd noticed something weird was happening sometimes; thanks for the motivation to look into it!

I haven't made use of userscript auto-updating before. I didn't see much useful official documentation, but I followed this great StackOverlow answer. As far as I can tell, it should work, but I haven't yet observed Tampermonkey performing an update. I notice that Tampermonkey's settings page has two different update interval settings - I'm not sure which would apply here, but the options are not very granular:

Screenshot from 2021-05-23 12-34-30

I think I'd prefer not to upload it to a site like Greasyfork if I don't have to, as it's another thing I'd have to maintain. I don't know that user discovery would benefit that much from it.

I mostly use it in the extension form myself, to reflect the experience of how I imagine most people will be using it. I'll try switching to Tampermonkey and decreasing the version number to try to see it perform an update.

from youtube-fast-fullscreen-toggle.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.