Git Product home page Git Product logo

Comments (7)

u-anurag avatar u-anurag commented on May 23, 2024

These functions look good. You are most welcome to create a pull request to add to the plotting functions or make the existing functions more efficient. There is PR #32 to reduce code repetition within the functions. I am working on documentation explaining what is going on inside the Get_Rendering library so others can easily modify it.

Also, how do you handle plotting mode shapes in OpenSeesPyTools? I couldn't see it in the functions.

from openseespy.

zhuminjie avatar zhuminjie commented on May 23, 2024

Thank you for contributing the codes. Just as @u-anurag said, you are very welcome to send PR with the source, documentation and examples. If two of you can have a conversations about how to merge your tools in the existing functions, it would be perfect.

For now, there isn't any tests setup for plotting functions. We may have to do it in the future. Thank you so much. I can't wait to see these plots.

from openseespy.

cslotboom avatar cslotboom commented on May 23, 2024

@u-anurag
Right now there isn't one, but it would be a easy add - it's just a matter of getting the mode shape with a function and using that as the displacement with the displacement plot.

@zhuminjie / @u-anurag
Where would be the best place for us to have that conversation? Here, or on #32?
I think ideally it would be somewhere public, for the sake of future developers.

@zhuminjie
I agree, it's probably a good idea to have a few test cases with a known output! Not sure where that would go in the existing repository.

from openseespy.

u-anurag avatar u-anurag commented on May 23, 2024

@cslotboom You can continue the public discussion on #17. Also, I have documented and tried to explain the working of Get_Rendering library in PR zhuminjie/OpenSeesPyDoc#190.

Please go through the code and see if you can add the animation function in it. Feel free to ask questions/discuss in #17.

from openseespy.

zhuminjie avatar zhuminjie commented on May 23, 2024

@u-anurag Thank you for initiating the discussion.

@cslotboom There are already tests in this folder

https://github.com/zhuminjie/OpenSeesPy/tree/master/openseespy-pip/openseespy/test

If you want, you add a new test file with name test_filename.py in that folder.

from openseespy.

cslotboom avatar cslotboom commented on May 23, 2024

@zhuminjie - I'm wondering if you know of a way that section geometric information can be returned via a command.
At some point, I'd love to be able to thicken elements.

from openseespy.

zhuminjie avatar zhuminjie commented on May 23, 2024

I saw you have posted on the OpenSeesPy Forum. I am going to close this one.

from openseespy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.